Skip to content

Clean up top-level directory structure

Shinya Kuribayashi u-boot 1 version New

Get series with b4
b4 am [email protected]

Versions newest first

  1. v2 Latest0 of 6 patches 0 repliesNew

Patches in v2 No applies recorded yet

None of the 6 patches the cover letter announces are in this archive.

Reviews trailers per patch

No Reviewed-by, Acked-by or Tested-by trailers for v2 yet.

Read the v2 thread

Cover letter [U-Boot] [PATCH v2 0/6] Clean up top-level directory structure
Quoted 47 lines · Peter Tyser
Quoted 19 lines · Jean-Christophe PLAGNIOL-VILLARD
Quoted 18 lines · Mike Frysinger
Quoted 5 lines · On Friday 10 July 2009 21:20:45 Shinya Kuribayashi wrote:
Quoted 4 lines · Peter Tyser
Quoted 4 lines

Before verifying MIPS builds, I'd like to make sure that why you take lib/$(ARCH)/ alternative, not $(ARCH)/lib/. If there were any discussion on #IRC, is there any chance we could share the summary or decision to follow?

Quoted 7 lines
Quoted 6 lines

There was no discussion, /lib/$(ARCH) just made more sense to me and it was functionally a direct translation from lib_$(ARCH) to lib/$(ARCH).

Using $(ARCH)/lib wouldn't clean up the top-level directory structure much and would open a can of worms that I'm not prepared to deal with at this time. For example, if there was an architecture specific

Oops, I wanted to say "arch/$(ARCH)/lib/", not $(ARCH)/lib/, sorry.

i thought that originally, but i dont care much either way. having arch/$(ARCH)/ would line up with u-boot-v2 and the linux kernel though.

i dont understand needing a lib/ subdir under arch/$(ARCH)/ though.

Quoted 8 lines
Quoted 5 lines
Quoted 5 lines
Quoted 3 lines

While we're talking about it, I'd always thought it would be nice to split out all the cmd_* files from common/ into their own command/ directory similar to u-boot-v2.

Ack. The directory structure in u-boot-v2 looks nice, at least, to me, anyway.

I prefer the
arch/$(ARCH)/lib
so will could also move the cpu stuff there too

I like the Linux and u-boot-v2 directory layout too the more I think about it too. How about if I resend this series but with the final directory structure looking like:

/arch/$(ARCH)/lib/<source files currently in lib_$(ARCH)

/lib/

	/<source files currently in lib_generic>
	/libfdt/
	/lzma/
	/lzo/

/examples/

	/api/
	/standalone/
Quoted 7 lines

That will lay the groundwork for moving additional files into /arch/$(ARCH)/ down the road. eg I think it would be nice to move the directories in /cpu/* into their respective /arch/$(ARCH)/ directory, and possibly the /include/asm-$(ARCH) directories in the long run.

What do others think of this?

There were some discussions we'd better to reflect back on about this topic.

I can't toss the URLs of them at the moment as I'm behind a firewall, but these might help:

Date: Thu, 13 Sep 2007 17:28:47 -0600
From: "Grant Likely" <[email protected]>
To: uboot <[email protected]>,
"Jon Loeliger" <[email protected]>,
"Wolfgang Denk" <[email protected]>
Subject: [U-Boot-Users] [RFC] u-boot migration to kconfig

and

Date: Sat, 22 Sep 2007 12:27:38 +0200
From: Jean-Christophe PLAGNIOL-VILLARD <[email protected]>
To: <[email protected]>
Subject: [U-Boot-Users] [RFC] u-boot migration to kconfig

Signature · 2 lines
Shinya Kuribayashi
NEC Electronics