Skip to content

dell-laptop improvements

Alan Jenkins linux-acpi linux-wireless lkml 1 version Applied

Status from this message: applied

Get series with b4
b4 am [email protected]

Versions newest first

  1. v1 Latest5 patches 7 repliesApplied

Patches in v1 Applied

#Subject and filesSizeRepliesApplied
1/5dell-laptop: fix a use-after-free error on the failure pathdrivers/platform/x86/dell-laptop.c+5 -31 reply
2/5dell-laptop: fix rfkill memory leak on unload and failure pathsdrivers/platform/x86/dell-laptop.c+18 -121 reply
3/5dell-laptop: create a platform device as a parent for the rfkill devices etc.drivers/platform/x86/dell-laptop.c+34 -40 replies
4/5dell-laptop: add __init to init functionsdrivers/platform/x86/dell-laptop.c+3 -31 reply
5/5dell-laptop: poll the rfkill hard-blockdrivers/platform/x86/dell-laptop.c+2 -23 replies

Reviews trailers per patch

No Reviewed-by, Acked-by or Tested-by trailers for v1 yet.

Read the v1 thread

Cover letter [PATCH 0/5] dell-laptop improvements

Mario Limonciello's compal-laptop changes were partly based on a reading of dell-laptop. Unfortunately dell-laptop set a few bad examples; let's fix them.

I don't have the hardware to test this, but the first four patches should be nice and low risk.

dell-laptop: fix a use-after-free error on the failure path
dell-laptop: fix rfkill memory leak on unload and failure paths
dell-laptop: create a platform device as a parent for the rfkill devices etc.
dell-laptop: add __init to init functions

The last patch adds polling for the hardware switch which blocks all radios. This exercises the hardware a little more than before; it would benefit from testing. It should be possible to see events generated by the hardware switch using "udevadm monitor --kernel --environment".

dell-laptop: poll the rfkill hard-block