RFC hrtimers: Remove unnecessary clock events device programming
Get series with b4
b4 am [email protected]Versions newest first
- v1 RFC Latest0 of 1 patch 0 repliesNew
Patches in v1 No applies recorded yet
The patch the cover letter announces is not in this archive.
Reviews trailers per patch
No Reviewed-by, Acked-by or Tested-by trailers for v1 yet.
Cover letter [RFC] [PATCH 0/1] hrtimers: Remove unnecessary clock events device programming
hrtimer_force_reprogram() was being called quite often unnecessarily. The following patch caches the hrtimer that causes the cpu_base->expires_next value to change. This way, we force the reprogram only when remove_hrtimer() finds that its going to remove an hrtimer which was about expire next. IOW, we forgo reprogramming the clock events device, if the current timer to be removed isn't at the root of the expires tree.
Also removed the hrtimer_is_queued check from remove_hrtimer and made appropriate changes to all callers. That check seemed redundant.
Results:
Shows ~60% reduction in the following calls to program clock events device.
- tick_nohz_restart_sched_tick (tick_sched_timer)
- hrtimer_start (tick_sched_timer)
I haven't traced all the callers yet, this was from a hack to timer_stats. If you guys have a better way to test this, I'll give that a go.
Tested on v2.6.29 on an ARM based embedded device.
Cheers,
Ashwin