Skip to content

make '-x'/'-i' option unnecessary for re-filtering.

Ken'ichi Ohmichi kexec 1 version In review

Get series with b4
b4 am [email protected]

Versions newest first

  1. v1 Latest4 of 5 patches 3 repliesIn review

4 of 5 patches are in this archive. The cover letter announces 5.

Patches in v1 No applies recorded yet

#Subject and filesSizeRepliesApplied
1/5Cleanup: Set a meaning value for KDUMP_SUB_HEADER_BLOCKS.diskdump_mod.h makedumpfile.c+1 -20 replies
2/5Cleanup: Fix some indents in write_kdump_header().makedumpfile.c+5 -60 replies
4/5Store vmcoreinfo data into a kdump-compressed dumpfile.diskdump_mod.h makedumpfile.c+43 -50 replies
5/5Read vmcoreinfo data from a kdump-compressed dumpfile.makedumpfile.c+5 -00 replies

Reviews trailers per patch

No Reviewed-by, Acked-by or Tested-by trailers for v1 yet.

Read the v1 thread

Cover letter [PATCH 0/5] make '-x'/'-i' option unnecessary for re-filtering.

Hi,

Quoted 13 lines · Ken'ichi Ohmichi

Hi CAI,

Thank you for testing and a good point.

Quoted 8 lines · CAI Qian
Quoted 8 lines

makedumpfile version 1.3.4 is released.
Your comments/patches are welcome.

Changelog:
o New feature
- Support kdump-compressed format for input file. (by Takao Indoh) A new makedumpfile can read dumpfile which is kdump-compressed format instead of /proc/vmcore and re-filter it.

Quoted 6 lines
Quoted 1 line

Does it need to specify either a vmlinux or vmcoreinfo file?

Yes, we need to do it for re-filtering now.
But it is not difficult to implement a feature that it is not necessary to specify either a vmlinux or vmcoreinfo file for re-filtering. I will try to implement the feature.

I created the patchset for implementing the above feature. Any comments/patches are welcome.

---
[PATCH 0/5] make '-x'/'-i' option unnecessary for re-filtering.

makedumpfile v1.3.4 can read a dumpfile which is kdump-compressed format instead of /proc/vmcore and re-filter it.

When re-filtering, it is necessary to specify '-x'/'-i' option. If not specifying, makedumpfile fails like the following:

 # ./makedumpfile -c -d 3 vmcore vmcore.1
 ...
 The dumpfile is saved to vmcore.1
 ...
 #
 # /makedumpfile -c -d 31 vmcore.1 vmcore.2
 vmcore.1 doesn't contain vmcoreinfo.
 Specify '-x' option or '-i' option.
 Commandline parameter is invalid.
 Try `makedumpfile --help' for more information.
 #

For usability, this patchset makes '-x'/'-i' option unnecessary for re-filtering.

Thanks
Ken'ichi Ohmichi

_______________________________________________
kexec mailing list
[email protected]
http://lists.infradead.org/mailman/listinfo/kexec