Skip to content

ocfs2: Some patches for reflink. v3

TaoMa ocfs2-devel 1 version New

Get series with b4
b4 am [email protected]

Versions newest first

  1. v1 Latest0 of 2 patches 0 repliesNew

Patches in v1 No applies recorded yet

None of the 2 patches the cover letter announces are in this archive.

Reviews trailers per patch

No Reviewed-by, Acked-by or Tested-by trailers for v1 yet.

Read the v1 thread

Cover letter [Ocfs2-devel] [PATCH 0/2] ocfs2: add trace event support for ocfs2
Quoted 23 lines · Joel Becker
Quoted 21 lines · Tao Ma

Hi Joel/Wengang,

Quoted 17 lines · Joel Becker
Quoted 2 lines · Wengang Wang

following patches add trace event support for ocfs2.

Wengang,
This looks like a nice start. Thank you for getting this going.
I'm sorry I haven't gotten back until now, I've been busy.
What I'd like to do next is get a small starting set of
tracepoints. You have one tracepoint in this patch as a good example, but we should get a few more. I don't want every mlog changed into a tracepoint. Some of them are old and useless :-) Instead, I'd like to find information we often want while debugging.
Tao, Tiger, and Sunil, what are parts of the code you often come
across when debugging? Certain mlog() prints you always find really important to see. If you point them out, Wengang can cook up tracepoints for them.

Quoted 9 lines
Quoted 2 lines

aops.c maybe? And recovery/dlm(The most awesome part)?

But what things? We're not just going to replace every mlog,
and we're not going to do every function. We really want to figure out what information is actually useful and add tracepoints for it. So if you have particular functions you need data on, or particular mlog() calls you always like to see, we'd love to hear about it.

No idea of recovery/dlm since I don't have much experience in it. As for aops.c, I think the most important part is ocfs2_write_begin_no_lock. It is very complicated, sometimes it will write inline_data, sometimes CoW a refcount record, sometimes makes a extent written. It is helpful for us to know some detail information about it.

Regards,
Tao

Quoted 8 lines

Wengang, dlmglue.c is definitely a place to look at. I'd love
to see events for the inc/dec of l_ro_holders and l_ex_holders. I'd also love to see the mlogs for 'BAST fired' and 'UNLOCK AST fired' converted, and a similar event for the regular AST.

Joel