Skip to content

gspca pac7302/pac7311: separate the two drivers

Németh Márton linux-media 1 version In review

Get series with b4
b4 am [email protected]

Versions newest first

  1. v1 Latest21 patches 4 repliesIn review

Patches in v1 No applies recorded yet

#Subject and filesSizeRepliesApplied
1/21gspca pac7302/pac7311: add prefix for sensor specific functionsdrivers/media/video/gspca/pac7311.c+10 -100 replies
2/21gspca pac7302/pac7311: separate sd_descdrivers/media/video/gspca/pac7311.c+22 -40 replies
3/21gspca pac7302/pac7311: separate pkt_scandrivers/media/video/gspca/pac7311.c+78 -250 replies
4/21gspca pac7302/pac7311: separate configdrivers/media/video/gspca/pac7311.c+34 -150 replies
5/21gspca pac7302/pac7311: separate initdrivers/media/video/gspca/pac7311.c+12 -90 replies
6/21gspca pac7302/pac7311: separate startdrivers/media/video/gspca/pac7311.c+33 -170 replies
7/21gspca pac7302/pac7311: separate stopNdrivers/media/video/gspca/pac7311.c+9 -100 replies
8/21gspca pac7302/pac7311: separate stop0drivers/media/video/gspca/pac7311.c+11 -100 replies
9/21gspca pac7302/pac7311: separate dq_callbackdrivers/media/video/gspca/pac7311.c+33 -190 replies
10/21gspca pac7302/pac7311: separate brightness and color controlsdrivers/media/video/gspca/pac7311.c+111 -210 replies
11/21gspca pac7302/pac7311: separate contrast controldrivers/media/video/gspca/pac7311.c+30 -120 replies
12/21gspca pac7302/pac7311: separate hvflipdrivers/media/video/gspca/pac7311.c+75 -300 replies
13/21gspca pac7302/pac7311: separate gain/autogain controldrivers/media/video/gspca/pac7311.c+94 -340 replies
14/21gspca pac7302/pac7311: separate exposuredrivers/media/video/gspca/pac7311.c+70 -330 replies
15/21gspca pac7302/pac7311: simplify pac_find_sofdrivers/media/video/gspca/mr97310a.c drivers/media/video/gspca/pac207.c drivers/media/video/gspca/pac7311.c +1 more+18 -180 replies
16/21gspca pac7302/pac7311: separate private sddrivers/media/video/gspca/pac7311.c+69 -540 replies
17/21gspca pac7302/pac7311: separate format descriptorsdrivers/media/video/gspca/pac7311.c+13 -50 replies
18/21gspca pac7302/pac7311: generalize reg_w_vardrivers/media/video/gspca/pac7311.c+11 -50 replies
19/21gspca pac7302/pac7311: extract pac_start_framedrivers/media/video/gspca/pac7311.c+26 -260 replies
20/21gspca pac7302/pac7311: separate the two subdriversdrivers/media/video/gspca/Kconfig drivers/media/video/gspca/Makefile drivers/media/video/gspca/pac7302.c +1 more+991 -7121 reply
21/21gspca pac7302/pac7311: remove prefixesdrivers/media/video/gspca/pac7302.c drivers/media/video/gspca/pac7311.c+226 -2301 reply

Reviews trailers per patch

No Reviewed-by, Acked-by or Tested-by trailers for v1 yet.

Read the v1 thread

Cover letter [PATCH 00/21] gspca pac7302/pac7311: separate the two drivers

Hi,

the following patchset refactores the Pixart PAC7311 subdriver. The current situation is that the code contains a lot of decisions like this:

    if (sd->sensor == SENSOR_PAC7302) {
        ... do this ...
    } else {
        ... do something else ...
    }

The sensor type is determined using the USB Vendor ID and Product ID which means that the decisions shown are not really necessary.

The goal of the patchset is to have a PAC7302 and a PAC7311 subdriver which have the benefit that there is no decision necessary on sensor type at runtime. The common functions can be extracted later but this would be a different patchset.

Regards,

Márton Németh