Skip to content

DRM/KMS framebuffer fixes

Clemens Ladisch linux-fbdev lkml 3 versions – New

Get series with b4
b4 am [email protected]

Versions newest first · linked by author and title

  1. v3 Latest3 patches 0 repliesNew
  2. v23 patches 1 replySuperseded
  3. v13 patches 1 replySuperseded

Patches in v3 No applies recorded yet

#Subject and filesSizeRepliesApplied
1/3drm/fb: fix FBIOGET/PUT_VSCREENINFO pixel clock handlingdrivers/gpu/drm/drm_fb_helper.c+3 -30 replies
2/3drm: set the type of the drm_framebuffer::fbdev fieldinclude/drm/drm_crtc.h+1 -10 replies
3/3drm/kms: allocate framebuffer cmapdrivers/gpu/drm/drm_fb_helper.c+7 -10 replies

Reviews trailers per patch

No Reviewed-by, Acked-by or Tested-by trailers for v3 yet.

Read the v3 thread

Cover letter [PATCH v3 0/3] DRM/KMS framebuffer fixes
Quoted 8 lines · James Simmons
Quoted 7 lines
(quoted diff) +3 -0
@@ -905,6 +905,9 @@ int drm_fb_helper_single_fb_probe(struct
 
 	if (new_fb) {
 		info->var.pixclock = 0;
+		ret = fb_alloc_cmap(&info->cmap, crtc->gamma_size, 0);
+		if (ret)
+			return ret;
Quoted 6 lines

Review int drm_fb_helper_single_fb_probe(struct · line 911

Quoted 1 line
(quoted diff) +0 -0
 		if (register_framebuffer(info) < 0) {

			fb_dealloc_cmap(info->cmap);

Review int drm_fb_helper_single_fb_probe(struct · line 912

Quoted 1 line
(quoted diff) +0 -0
 			return -EINVAL;

		}

Plug memory leak.

Oops. Thanks again.
New patch set follows:

 include/drm/drm_crtc.h          |    2 +-
 drivers/gpu/drm/drm_fb_helper.c |   14 ++++++++++----
 2 files changed, 11 insertions(+), 5 deletions(-)

v2: incorporated suggestions by James Simmons
v3: bugfix by James Simmons

Read the cover letter in its thread