RFC state lock reduction prep
Get series with b4
b4 am [email protected]Versions newest first
- v1 RFC Latest11 patches 12 repliesIn review
Patches in v1 No applies recorded yet
| # | Subject and files | Size | Replies | Applied |
|---|---|---|---|---|
| 1/11 | nfsd: introduce nfs4_client statefs/ | +8 | 2 replies | |
| 2/11 | nfsd: mark client state as expired in expire_clientfs/ | +1 | 0 replies | |
| 3/11 | nfsd: introduce get_nfs4_clientfs/ fs/ fs/ | +8 | 0 replies | |
| 4/11 | nfsd: mark client for renewfs/ fs/ fs/ +1 more | +42 | 6 replies | |
| 5/11 | nfsd: skip clients marked for renewalfs/ | +3 | 2 replies | |
| 6/11 | nfsd41: no need to hold the state lock around mark_client_for_renewfs/ | +1 | 0 replies | |
| 7/11 | nfsd: rename recall_lock to deleg_lockfs/ | +18 | 0 replies | |
| 8/11 | nfsd: use deleg_lock to protect dl_perfile and dl_perclntfs/ | +8 | 0 replies | |
| 9/11 | nfsd: get a reference count on the delgation while outside of the deleg_lockfs/ | +7 | 0 replies | |
| 10/11 | nfsd: close delegation only on last referencefs/ | +13 | 2 replies | |
| 11/11 | nfsd: refactor unhash_delegationfs/ | +13 | 0 replies |
Reviews trailers per patch
No Reviewed-by, Acked-by or Tested-by trailers for v1 yet.
Cover letter [RFC 0/11] state lock reduction prep
Bruce,
The following patches implement the first phase in preparation for reducing the scope in we which we hold the state lock mutex.
[RFC 01/11] nfsd: introduce nfs4_client state
[RFC 02/11] nfsd: mark client state as expired in expire_client [RFC 03/11] nfsd: introduce get_nfs4_client
[RFC 04/11] nfsd: mark client for renew
[RFC 05/11] nfsd: skip clients marked for renewal
[RFC 06/11] nfsd41: no need to hold the state lock around mark_client_for_renew
the patches above use an atomic cl_state field to manage the nfs4_client expire vs. renew state so this can be done outside the state lock.
[RFC 07/11] nfsd: rename recall_lock to deleg_lock
[RFC 08/11] nfsd: use deleg_lock to protect dl_perfile and dl_perclnt
[RFC 09/11] nfsd: get a reference count on the delgation while outside of the deleg_lock [RFC 10/11] nfsd: close delegation only on last reference
[RFC 11/11] nfsd: refactor unhash_delegation
The patches above augment the use of the recall_lock spinlock (and rename it to deleg_lock) and grab a reference count on the delegation structure while not protected by the deleg_lock. The delegation's respective file will be closed only on last dereference, so the deleg structure could be used safely while not holding the state_lock and potentially in parallel to expire_client being called (and unhashing the delegation)
The next steps I see are:
1. use a spinlock for traversing the nfs4_client hash lists
2. use a spinlock for traversing the nfs4_stateowner lists
Eventually, reducing the state_lock scope for complex state changes requiring the coordination of state across multiple lists and involving blocking ops (e.g. allocation, manipulating clid_dir) in particular there should be no need to hold the state lock for expire_client.
Benny