Skip to content

LTP Memory controller smarter check for enable/disable functionality

Rishikesh ltp 1 version In review

Get series with b4
b4 am [email protected]

Versions newest first

  1. v1 Latest2 patches 7 repliesIn review

Patches in v1 No applies recorded yet

#Subject and filesSizeRepliesApplied
1/2: Added check to test_controller.shtestcases/kernel/controllers/test_controllers.sh+19 -111 reply
2/2Added check for memory controller ( functional, regression & stress )testcases/kernel/controllers/memcg/functional/memcg_function_test.sh testcases/kernel/controllers/memcg/regression/memcg_regression_test.sh testcases/kernel/controllers/memcg/stress/memcg_stress_test.sh+18 -86 replies

Reviews trailers per patch

All 2 patches have a Reviewed-by or Acked-by.

PatchLi Zefan
1/2A-b
2/2A-b

Trailers given in replies are filled; those carried in the patches from earlier versions are outlined with dashes.

Read the v1 thread

Cover letter [LTP] [PATCH 0/2 ] LTP Memory controller smarter check for enable/disable functionality

Hi All,

Current memory controller implelementation in LTP does not check if memory controller is enabled or not. It only check for memory contorller kernel support. It may happen that some distro would have disabled functionality. e.g:

mhs21a:/opt/ltp # cat /proc/cgroups | grep -e num_ -e memory -e freezer
#subsys_name hierarchy num_cgroups enabled
memory 0 1 0
freezer 0 1 1
mhs21a:/opt/ltp #

Here 4th parameter shows the exact support for functionality as enabled/disabled. As here clearly it shows that memory controller is disabled and freezer is enabled.

My patch supports for this functionality.

[PATCH 1/2 ] : Added check for all controller to LTP. [PATCH 2/2 ] : Added check to memory controller functiona,regression & stress testcase scripts.

Comments are welcome.

It has been tested and here are the result.

Without applying patch:

===========================================

<<snip>>
<<<execution_status>>>
initiation_status="ok"
duration=124 termination_type=exited termination_id=0 corefile=no cutime=2046 cstime=4111
<<<test_end>>>
<<<test_start>>>
tag=memcg_regression stime=1261991350 cmdline="memcg_regression_test.sh"
contacts=""
analysis=exit
<<<test_output>>>
mount: wrong fs type, bad option, bad superblock on xxx,
missing codepage or helper program, or other error (for several filesystems (e.g. nfs, cifs) you might need a /sbin/mount.<type> helper program)
In some cases useful info is found in syslog - try dmesg | tail or so

memcg_regression_test 1 TFAIL : failed to mount memory subsytem
mount: wrong fs type, bad option, bad superblock on xxx,
missing codepage or helper program, or other error (for several filesystems (e.g. nfs, cifs) you might need a /sbin/mount.<type> helper program) In some cases useful info is found in syslog - try dmesg | tail or so
<<snip>>

==============================================

And with patch:

===========================================
<<snip>>

Running tests.......
<<<test_start>>>
tag=memcg_regression stime=1261996253 cmdline="memcg_regression_test.sh"
contacts=""
analysis=exit
<<<test_output>>>
WARNING:
Kernel does not support for memory resource controller Skipping all memcgroup testcases.... <<<execution_status>>>
initiation_status="ok"
duration=0 termination_type=exited termination_id=0 corefile=no cutime=0 cstime=0
<<<test_end>>>
<<<test_start>>>
tag=memcg_function stime=1261996253
cmdline=" memcg_function_test.sh"
contacts=""
analysis=exit
<<<test_output>>>
WARNING:
Kernel does not support for memory resource controller Skipping all memcgroup testcases.... <<<execution_status>>>
initiation_status="ok"
duration=0 termination_type=exited termination_id=0 corefile=no cutime=1 cstime=0
<<<test_end>>>
<<<test_start>>>
tag=memcg_stress stime=1261996253
cmdline=" memcg_stress_test.sh"
contacts=""
analysis=exit
<<<test_output>>>
incrementing stop
WARNING:
Kernel does not support for memory resource controller Skipping all memcgroup testcases.... <<<execution_status>>>
initiation_status="ok"
duration=0 termination_type=exited termination_id=0 corefile=no cutime=0 cstime=0
<<<test_end>>>
INFO: ltp-pan reported all tests PASS
LTP Version: LTP-20091130
<<snip>>
=============================================

Thanks
Rishi

------------------------------------------------------------------------------
This SF.Net email is sponsored by the Verizon Developer Community Take advantage of Verizon's best-in-class app development support A streamlined, 14 day to market process makes app distribution fast and easy Join now and get one step closer to millions of Verizon customers
http://p.sf.net/sfu/verizon-dev2dev
_______________________________________________
Ltp-list mailing list
[email protected]
https://lists.sourceforge.net/lists/listinfo/ltp-list