Skip to content

sky2: Avoid down and up during sky2_reset

Mike McCormack netdev 1 version In review

Get series with b4
b4 am [email protected]

Versions newest first

  1. v1 Latest5 patches 2 repliesIn review

Patches in v1 No applies recorded yet

#Subject and filesSizeRepliesApplied
1/5sky2: Factor out code to calculate packet sizesdrivers/net/sky2.c+37 -200 replies
2/5sky2: Allocate initial skbs in sky2_alloc_buffersdrivers/net/sky2.c+38 -301 reply
3/5sky2: Refactor sky2_up into two functionsdrivers/net/sky2.c+25 -160 replies
4/5sky2: Refactor sky2_down into two functionsdrivers/net/sky2.c+17 -110 replies
5/5sky2: Avoid down and up during sky2_resetdrivers/net/sky2.c+49 -211 reply

Reviews trailers per patch

No Reviewed-by, Acked-by or Tested-by trailers for v1 yet.

Read the v1 thread

Cover letter [PATCH 0/5] sky2: Avoid down and up during sky2_reset

Hi Stephen,

This patch set reimplements sky2_reset so that

* interrupts are disabled during reset
* memory is not free'd and reallocated
* tx queues are stopped during reset, but the device is not brought down

Additionally, it avoids partial initialization of the hardware when ring buffer allocation fails.

The rx ring still needs to be fully allocated for sky2_up to succeed.

thanks,

Mike