Skip to content

xl: Add subcommand mem-max and fix mem-set

Yu Zhiguo xen-devel 1 version In review

Get series with b4
b4 am [email protected]

Versions newest first

  1. v1 Latest2 patches 5 repliesIn review

Patches in v1 No applies recorded yet

#Subject and filesSizeRepliesApplied
1/2xl: Add command 'xl mem-max'tools/libxl/libxl.c tools/libxl/libxl.h tools/libxl/xl_cmdimpl.c +2 more+93 -00 replies
2/2xl: Add check for command 'xl mem-set'tools/libxl/libxl.c+23 -50 replies

Reviews trailers per patch

None of the 2 patches has a Reviewed-by or Acked-by of their own; the series has one for all of them.

PatchJonathan Knowles
SeriesA-b
1/2
2/2

Trailers given in replies are filled; those carried in the patches from earlier versions are outlined with dashes.

Read the v1 thread

Cover letter [PATCH 0/2] xl: Add subcommand mem-max and fix mem-set
Quoted 12 lines · Yu Zhiguo

I'm trying to add subcommand 'mem-max', I think xc_domain_setmaxmem should be used in it but not here.

I'll move this code to 'mem-max', and in 'mem-set', a check should be added because setting memory larger than max memory is invalid.

1. Add 'mem-max'
Add libxl_domain_setmaxmem, it calls xc_domain_setmaxmem. /local/domain/$domid/memory/static-max should be updated when set max memory,
it is missing now.

Quoted 5 lines

2. fix 'mem-set'
Delete xc_domain_setmaxmem.
Get max memory from /local/domain/$domid/memory/static-max, and then do value check.
It seems that we cannot get max memory use libxc routines.

I fixed it, please check.

[PATCH 1/2] xl: Add command 'xl mem-max' [PATCH 2/2] xl: Add check for command 'xl mem-set'

Regards
Yu Zhiguo