Skip to content

RFC ep93xx i2s audio

Ryan Mallon alsa-devel linux-arm-kernel 3 versions – In review

Get series with b4
b4 am [email protected]

Versions newest first · linked by author and title

  1. v3 RFC Latest3 patches 8 repliesIn review
  2. v2 RFC3 patches 6 repliesSuperseded
  3. v1 RFC0 of 3 patches 0 repliesSuperseded

Patches in v3 No applies recorded yet

#Subject and filesSizeRepliesApplied
1/3ep93xx i2s core supportarch/arm/mach-ep93xx/clock.c arch/arm/mach-ep93xx/core.c arch/arm/mach-ep93xx/include/mach/ep93xx-regs.h +1 more+110 -12 replies
2/3ep93xx i2s audio driversound/soc/Kconfig sound/soc/Makefile sound/soc/ep93xx/Kconfig +5 more+865 -00 replies
3/3Snapper cl15 audio supportarch/arm/mach-ep93xx/snappercl15.c sound/soc/ep93xx/Kconfig sound/soc/ep93xx/Makefile +1 more+156 -00 replies

Reviews trailers per patch

1 of 3 patches has a Reviewed-by or Acked-by of their own; the series has one for all of them.

PatchLiam GirdwoodH Hartley Sweeten
SeriesA-b
1/3A-b
2/3
3/3

Trailers given in replies are filled; those carried in the patches from earlier versions are outlined with dashes.

Read the v3 thread

Cover letter [RFC PATCH v3 0/3] ep93xx i2s audio

The following patch series adds support for i2s audio on the ep93xx, with the Snapper CL15 used as an example implementation.

This version fixes a number of things from the previous round:
- Removed unused #defines
- Set symmetric rates for the cpu dai
- Fixed the sdiv/lrdiv calculation loop
- Moved the cpu dai registration
- Removed empty ep93xx_pcm_prepare callback
- Fixed enable/disable when both capture and playback are running

Capture still does not work. The dma is running, but the captured data is all zeros (tested used arecord and loopback). I have a 2.6.20 kernel with ep93xx i2s audio working an capture works there on the same hardware. I have spent sometime looking into this, but can't see the problem. Would appreciate if someone can lend some insight as to what I have done wrong.

Ryan Mallon (3):
ep93xx i2s core support
ep93xx i2s audio driver
Snapper cl15 audio support

 arch/arm/mach-ep93xx/clock.c                    |   69 ++++-
 arch/arm/mach-ep93xx/core.c                     |   31 ++
 arch/arm/mach-ep93xx/include/mach/ep93xx-regs.h |   10 +
 arch/arm/mach-ep93xx/include/mach/platform.h    |    1 +
 arch/arm/mach-ep93xx/snappercl15.c              |    1 +
 sound/soc/Kconfig                               |    1 +
 sound/soc/Makefile                              |    1 +
 sound/soc/ep93xx/Kconfig                        |   18 +
 sound/soc/ep93xx/Makefile                       |   11 +
 sound/soc/ep93xx/ep93xx-i2s.c                   |  487 +++++++++++++++++++++++
 sound/soc/ep93xx/ep93xx-i2s.h                   |   18 +
 sound/soc/ep93xx/ep93xx-pcm.c                   |  319 +++++++++++++++
 sound/soc/ep93xx/ep93xx-pcm.h                   |   22 +
 sound/soc/ep93xx/snappercl15.c                  |  143 +++++++
 14 files changed, 1131 insertions(+), 1 deletions(-)
 create mode 100644 sound/soc/ep93xx/Kconfig
 create mode 100644 sound/soc/ep93xx/Makefile
 create mode 100644 sound/soc/ep93xx/ep93xx-i2s.c
 create mode 100644 sound/soc/ep93xx/ep93xx-i2s.h
 create mode 100644 sound/soc/ep93xx/ep93xx-pcm.c
 create mode 100644 sound/soc/ep93xx/ep93xx-pcm.h
 create mode 100644 sound/soc/ep93xx/snappercl15.c