Skip to content

Basic device state visualization

Jan Kiszka qemu-devel 3 versions – In review

Get series with b4
b4 am [email protected]

Versions newest first · linked by author and title

  1. v3 Latest17 patches 24 repliesIn review
  2. v215 patches 37 repliesSuperseded
  3. v11 patch 2 repliesApplied

Patches in v3 No applies recorded yet

#Subject and filesSizeRepliesApplied
1/17Add dependency of JSON unit tests on config-host.hMakefile+2 -00 replies
2/17qdev: Fix scanning across single-bus devicesdocs/qdev-device-use.txt hw/qdev.c+15 -12 replies
3/17qdev: Allow device addressing via 'driver.instance'docs/qdev-device-use.txt hw/qdev.c+31 -60 replies
4/17qdev: Give qtree names precedence over user-assigned IDsdocs/qdev-device-use.txt hw/qdev.c+12 -1022 replies
5/17qdev: Convert device and bus lists to QTAILQhw/acpi_piix4.c hw/i2c.c hw/pci-hotplug.c +3 more+32 -310 replies
6/17qdev: Allow device specification by qtree path for device_delhw/qdev.c qemu-monitor.hx+48 -118 replies
7/17qdev: Push QMP mode checks into qbus_list_bus/devhw/qdev.c+10 -120 replies
8/17monitor: Add completion for qdev pathshw/qdev.c hw/qdev.h monitor.c +1 more+123 -160 replies
9/17Add base64 encoder/decoderMakefile.objs base64.c base64.h+222 -10 replies
10/17QMP: Reserve namespace for complex object classesQMP/qmp-spec.txt+13 -32 replies
11/17Add QBufferMakefile Makefile.objs QMP/qmp-spec.txt +6 more+351 -50 replies
12/17monitor: return length of printed string via monitor_[v]printfmonitor.c monitor.h qemu-tool.c+21 -121 reply
13/17monitor: Allow to exclude commands from QMPmonitor.c+10 -35 replies
14/17monitor: Add basic device state visualizationhw/hw.h hw/qdev.c hw/qdev.h +3 more+273 -00 replies
15/17QMP: Teach basic capability negotiation to python exampleQMP/qmp-shell QMP/vm-info+2 -00 replies
16/17QMP: Fix python helper /wrt long return stringsQMP/qmp.py+5 -11 reply
17/17QMP: Add support for buffer class to qmp python helperQMP/qmp.py+23 -20 replies

Reviews trailers per patch

1 of 17 patches has a Reviewed-by or Acked-by.

PatchGerd Hoffmann
1/17
2/17
3/17
4/17A-b A-b
5/17
6/17
7/17
8/17
9/17
10/17
11/17
12/17
13/17
14/17
15/17
16/17
17/17

Trailers given in replies are filled; those carried in the patches from earlier versions are outlined with dashes.

Read the v3 thread

Cover letter [Qemu-devel] [PATCH v3 00/17] Basic device state visualization

And here is v3. Dependencies remained, the changes are:
- disabled device_show for QMP use (due to protocol instability)
- reordered device tree path search: user-assigned ID comes last now
- added vmstate version-id to device_show output
- base64 cleanups according to review comments
- fixed an off-by-one in the qmp.py changes

Git url remained the same:

git://git.kiszka.org/qemu.git queues/device-show

Thanks again for the comments.

Jan Kiszka (17):
Add dependency of JSON unit tests on config-host.h
qdev: Fix scanning across single-bus devices
qdev: Allow device addressing via 'driver.instance'
qdev: Give qtree names precedence over user-assigned IDs
qdev: Convert device and bus lists to QTAILQ
qdev: Allow device specification by qtree path for device_del
qdev: Push QMP mode checks into qbus_list_bus/dev
monitor: Add completion for qdev paths
Add base64 encoder/decoder
QMP: Reserve namespace for complex object classes Add QBuffer
monitor: return length of printed string via monitor_[v]printf
monitor: Allow to exclude commands from QMP
monitor: Add basic device state visualization
QMP: Teach basic capability negotiation to python example
QMP: Fix python helper /wrt long return strings
QMP: Add support for buffer class to qmp python helper

 Makefile                 |    5 +-
 Makefile.objs            |    4 +-
 QMP/qmp-shell            |    1 +
 QMP/qmp-spec.txt         |   24 +++-
 QMP/qmp.py               |   29 +++-
 QMP/vm-info              |    1 +
 base64.c                 |  202 ++++++++++++++++++++++
 base64.h                 |   19 ++
 check-qbuffer.c          |  172 +++++++++++++++++++
 configure                |    2 +-
 docs/qdev-device-use.txt |   20 ++-
 hw/acpi_piix4.c          |    2 +-
 hw/hw.h                  |    2 +
 hw/i2c.c                 |    2 +-
 hw/pci-hotplug.c         |    2 +-
 hw/qdev.c                |  414 ++++++++++++++++++++++++++++++++++++++++-----
 hw/qdev.h                |   12 +-
 hw/ssi.c                 |    6 +-
 monitor.c                |  121 ++++++++++++--
 monitor.h                |    4 +-
 qbuffer.c                |  116 +++++++++++++
 qbuffer.h                |   33 ++++
 qemu-monitor.hx          |   29 +++-
 qemu-tool.c              |    6 +-
 qerror.c                 |    4 +
 qerror.h                 |    3 +
 qjson.c                  |   15 ++
 qobject.h                |    1 +
 28 files changed, 1165 insertions(+), 86 deletions(-)
 create mode 100644 base64.c
 create mode 100644 base64.h
 create mode 100644 check-qbuffer.c
 create mode 100644 qbuffer.c
 create mode 100644 qbuffer.h