Skip to content

: merge pnfs client ops into nfs4's

Benny Halevy linux-nfs 1 version In review

Get series with b4
b4 am [email protected]

Versions newest first

  1. v1 Latest19 patches 7 repliesIn review

Patches in v1 No applies recorded yet

#Subject and filesSizeRepliesApplied
1/19SQUASHME: pnfs-submit: merge pnfs4_proc_setattr into nfs4_proc_setattrfs/nfs/nfs4proc.c+15 -202 replies
2/19SQUASHME: pnfs4_read_done status variable is unusedfs/nfs/nfs4proc.c+0 -30 replies
3/19SQUASHME: pnfs-submit: optionally pass nfs_client to nfs4_async_handle_errorfs/nfs/nfs4proc.c+6 -160 replies
4/19SQUASHME: pnfs-submit: merge pnfs4_read_done into nfs4_read_done - part 1fs/nfs/nfs4proc.c+5 -01 reply
5/19SQUASHME: pnfs-submit: merge pnfs4_read_done into nfs4_read_done - part 2fs/nfs/nfs4proc.c+9 -20 replies
6/19SQUASHME: pnfs-submit: merge pnfs4_read_done into nfs4_read_done - part 3fs/nfs/nfs4proc.c+1 -12 replies
7/19SQUASHME: pnfs-submit: get rid of pnfs4_read_donefs/nfs/nfs4proc.c+0 -430 replies
8/19SQUASHME: pnfs-submit: merge pnfs4_write_done into nfs4_write_done - part 1fs/nfs/nfs4proc.c+10 -10 replies
9/19SQUASHME: pnfs-submit: merge pnfs4_write_done into nfs4_write_done - part 2fs/nfs/nfs4proc.c+3 -02 replies
10/19SQUASHME: pnfs-submit: merge pnfs4_write_done into nfs4_write_done - part 3fs/nfs/nfs4proc.c+12 -40 replies
11/19SQUASHME: pnfs-submit: merge pnfs4_write_done into nfs4_write_done - part 4fs/nfs/nfs4proc.c+18 -20 replies
12/19SQUASHME: pnfs-submit: get rid of pnfs4_write_donefs/nfs/nfs4proc.c+0 -590 replies
13/19SQUASHME: pnfs-submit: merge pnfs4_commit_done into nfs4_commit_done - part 1fs/nfs/nfs4proc.c+5 -00 replies
14/19SQUASHME: pnfs-submit: merge pnfs4_commit_done into nfs4_commit_done - part 2fs/nfs/nfs4proc.c+11 -30 replies
15/19SQUASHME: pnfs-submit: merge pnfs4_commit_done into nfs4_commit_done - part 3fs/nfs/nfs4proc.c+2 -10 replies
16/19SQUASHME: pnfs-submit: get rid of pnfs4_commit_donefs/nfs/nfs4proc.c+0 -360 replies
17/19SQUASHME: pnfs-submit: merge pnfs4_proc_write_setup into nfs4_proc_write_setupfs/nfs/nfs4proc.c+7 -230 replies
18/19SQUASHME: pnfs-submit: merge pnfs4_proc_commit_setup into nfs4_proc_commit_setupfs/nfs/nfs4proc.c+6 -220 replies
19/19SQUASHME: pnfs-submit: get rid of pnfs_v4_clientopsfs/nfs/internal.h fs/nfs/nfs4proc.c fs/nfs/pnfs.c+0 -230 replies

Reviews trailers per patch

No Reviewed-by, Acked-by or Tested-by trailers for v1 yet.

Read the v1 thread

Cover letter [PATCH 0/19]: merge pnfs client ops into nfs4's

The following patchset folds the pnfs client ops into their nfs4 counterparts.

Note that the pnfs implementation forked off of old versions of the nfs ops but we failed to update the pnfs implementation when the original code they were derived from changed so the current state captures an unintentional deviation.

Merging back the code ensures that the common paths are correctly used and we deal only with the pnfs-specific functionality.

This solves the bug where we were using two client structures when mounting the server more than once and seeing the session destroyed repeatedly (and the server returning 10052 on DESTROY_SESSION) and eventually hitting the session recovery deadlock reported here:
http://marc.info/?l=linux-nfs&m=127663654927724&w=2

Here's the list of patches:
[PATCH 01/19] SQUASHME: pnfs-submit: merge pnfs4_proc_setattr into nfs4_proc_setattr [PATCH 02/19] SQUASHME: pnfs4_read_done status variable is unused
[PATCH 03/19] SQUASHME: pnfs-submit: optionally pass nfs_client to nfs4_async_handle_error [PATCH 04/19] SQUASHME: pnfs-submit: merge pnfs4_read_done into nfs4_read_done - part 1 [PATCH 05/19] SQUASHME: pnfs-submit: merge pnfs4_read_done into nfs4_read_done - part 2 [PATCH 06/19] SQUASHME: pnfs-submit: merge pnfs4_read_done into nfs4_read_done - part 3 [PATCH 07/19] SQUASHME: pnfs-submit: get rid of pnfs4_read_done
[PATCH 08/19] SQUASHME: pnfs-submit: merge pnfs4_write_done into nfs4_write_done - part 1 [PATCH 09/19] SQUASHME: pnfs-submit: merge pnfs4_write_done into nfs4_write_done - part 2 [PATCH 10/19] SQUASHME: pnfs-submit: merge pnfs4_write_done into nfs4_write_done - part 3 [PATCH 11/19] SQUASHME: pnfs-submit: merge pnfs4_write_done into nfs4_write_done - part 4 [PATCH 12/19] SQUASHME: pnfs-submit: get rid of pnfs4_write_done
[PATCH 13/19] SQUASHME: pnfs-submit: merge pnfs4_commit_done into nfs4_commit_done - part 1 [PATCH 14/19] SQUASHME: pnfs-submit: merge pnfs4_commit_done into nfs4_commit_done - part 2 [PATCH 15/19] SQUASHME: pnfs-submit: merge pnfs4_commit_done into nfs4_commit_done - part 3 [PATCH 16/19] SQUASHME: pnfs-submit: get rid of pnfs4_commit_done
[PATCH 17/19] SQUASHME: pnfs-submit: merge pnfs4_proc_write_setup into nfs4_proc_write_setup [PATCH 18/19] SQUASHME: pnfs-submit: merge pnfs4_proc_commit_setup into nfs4_proc_commit_setup [PATCH 19/19] SQUASHME: pnfs-submit: get rid of pnfs_v4_clientops