Skip to content

RFC arm: add full relocation / cache support

Heiko Schocher u-boot 1 version New

Get series with b4
b4 am [email protected]

Versions newest first

  1. v1 RFC Latest0 of 19 patches 0 repliesNew

Patches in v1 No applies recorded yet

None of the 19 patches the cover letter announces are in this archive.

Reviews trailers per patch

No Reviewed-by, Acked-by or Tested-by trailers for v1 yet.

Read the v1 thread

Cover letter [U-Boot] [RFC][PATCH 00/19] arm: add full relocation / cache support

Hello Matthias,

Quoted 9 lines · Matthias Wei?er

Am 29.07.2010 12:44, schrieb Heiko Schocher:

Quoted 7 lines

This patch series add full relocation and cache support for arm based boards. I did this for arm1136, arm_cortexa8 and arm926ejs based boards. As this change is not compatible to old code, before this can go to mainline *all* plattforms and boards have to be converted! As I don;t have access to all plattforms/ boards I need help here! Also I couldn;t test all boards, so please test and report, send bugfixes!

Quoted 3 lines

I just tested your patch set on my version of u-boot for MB86R01 from Fujitsu (arm926ejs based SoC). This is currently not available in mainline u-boot but current patches are available here

Thanks for testing!

Quoted 4 lines

http://lists.denx.de/pipermail/u-boot/2010-August/074688.html

The point is that the board doesn't boot after applying your patches and doing the changes to my board which are given at the end of this mail.

:-(

Quoted 2 lines

The board runs through my low level init (so DDR RAM is up) and later on crashes in the first call to memset. I could not further debug this as I

Where is this memset()? The first after low level init is in:
arch/arm/lib/board.c board_init_f(), do you mean this?

If so, then something must be wrong with your memory setup.

Quoted 2 lines

have to admit that I am not an expert with GDB + BDI2000 debugging. Maybe you can give me some hints what I am missing.

Hmm.. hard to say without debugging it. If you don;t mean with "crashes in the first first memset" the function I above described, maybe maybe your Ram gets not correct detected? Can you try to find out, with what value dram_init() sets up gd->ram_size?
(Or you set this for testing to fix values?)

Hmmm... from where did your board boot? I tried it on the tx25 board, which boots from nand. Do you boot from a NOR flash? If so you *must* change TEXT_BASE in config.mk (see:
doc/README.arm-relocation line 45) in your board directory to where u-boot starts in flash!

Ah, yep, this seems to me the reason why it don;t work for you:

found in the patchseries you pointed to
http://lists.denx.de/pipermail/u-boot/2010-August/074688.html

board/syteco/jadecpu/config.mk
[...]
+TEXT_BASE = 0x46000000

change this to

(as in include/configs/jadecpu.h is defined the following:

+/*
+ * FLASH and environment organization
+ */
+#define CONFIG_SYS_FLASH_BASE 0x10000000
+#define CONFIG_SYS_MAX_FLASH_BANKS 1
+#define CONFIG_SYS_MAX_FLASH_SECT 256
+#define CONFIG_SYS_MONITOR_BASE CONFIG_SYS_FLASH_BASE
)

+TEXT_BASE = 0x10000000

and try it again.

Quoted 33 lines

Changes made to the board code after applying your patches:

include/configs/jadecpu.h +0 -0
index bfc60a6..24aa23d 100644
@@ -149,6 +149,10 @@
 #define PHYS_SDRAM             0x40000000      /* Start address of

DDRRAM */
#define PHYS_SDRAM_SIZE 0x08000000 /* 128 megs */

include/configs/jadecpu.h +4 -0
+/* additions for new relocation code, must added to all boards */
+#define CONFIG_SYS_SDRAM_BASE          PHYS_SDRAM
+#define CONFIG_SYS_INIT_SP_ADDR                0x01000000
+
 /*
  * FLASH and environment organization
  */
board/syteco/jadecpu/jadecpu.c +2 -3
index 04d2f9d..bf96bcd 100644
@@ -154,12 +154,18 @@ int misc_init_r(void)
  */
 int dram_init(void)
 {
-       gd->bd->bi_dram[0].start = PHYS_SDRAM;
-       gd->bd->bi_dram[0].size = PHYS_SDRAM_SIZE;
-
+       /* dram_init must store complete ramsize in gd->ram_size */
+       gd->ram_size = get_ram_size((volatile void *)PHYS_SDRAM,

board/syteco/jadecpu/jadecpu.c int misc_init_r(void) · line 168

Quoted 10 lines
board/syteco/jadecpu/jadecpu.c +7 -0
+                               PHYS_SDRAM_SIZE);
        return 0;
 }
 
+void dram_init_banksize (void)
+{
+       gd->bd->bi_dram[0].start = PHYS_SDRAM;
+       gd->bd->bi_dram[0].size = gd->ram_size;
+}
+

looks OK to me.

bye
Heiko

Signature · 2 lines
DENX Software Engineering GmbH,     MD: Wolfgang Denk & Detlev Zundel
HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany

Read the cover letter in its thread