Add disk support to orion5x and edminiv2

Le 05/08/2010 16:28, Rogan Dawes a ?crit :

Quoted 11 lines · Albert ARIBAUD

Quoted 3 lines

Rogan, what other code do you think you'd be duplicating?

Amicalement,

In truth, I was really thinking only of the config files, not really the code per se.

I suppose that there is not really that much else that really is common.

Rogan

As for the configs, some u-boot boards do commonalize, see for instance include/configs/spear*.h. That makes sense because there is a board family, with a common HW design and common external components.

For instance, the recently submitted patch for the kirkwood-based openrd family could probably commonalize since most of the OpenRD Base and OpenRD Client HW design is shared, and I assume Ultimate reuses it a lot too.

In our case, the boards are from different manufacturers, so commonalization seems less obvious to me, except for MV88E1116 if both boards have it, but the config for it is a single define (CONFIG_RESET_PHY_R) which makes putting it in a common config header overkill (but commonalization of reset code would make sense though).

Amicalement,