checkout: diff.ignoreSubmodules: Add test and honor per submodule settings too
Get series with b4
b4 am [email protected]Versions newest first
- v1 Latest2 patches 0 repliesNew
Patches in v1 No applies recorded yet
| # | Subject and files | Size | Replies | Applied |
|---|---|---|---|---|
| 1/2 | checkout: Add test for diff.ignoreSubmodulesDocumentation/ t/ | +9 | 0 replies | |
| 2/2 | checkout: Use submodule.*.ignore settings from .git/config and .gitmodulesbuiltin/ t/ | +21 | 0 replies |
Reviews trailers per patch
No Reviewed-by, Acked-by or Tested-by trailers for v1 yet.
Cover letter [PATCH 0/2] checkout: diff.ignoreSubmodules: Add test and honor per submodule settings too
Am 25.08.2010 23:57, schrieb Jens Lehmann:
Quoted 4 lines
Am 25.08.2010 22:10, schrieb Junio C Hamano:
Quoted 1 line
Thanks. Perhaps we would want a new test or two in t2013?
Sure, I will add some as soon as I find some time ...
Ok, here we go!
While writing the test I noticed it might be nice to use the configuration settings consistently. So I did a second patch teaching checkout to honor the submodule.*.ignore settings the same way diff and status do.
Two other issues surfaced while working on these patches:
1) We might have to teach the --ignore-submodules option to checkout too to be able to override the configuration on the command line and in scripts.
2) It might be a good idea to let "git status" honor the diff.ignoreSubmodules setting too, so that the output is consistent with that of diff and checkout.
Opinions?
(While I am willing to write the patches, I am not a user of these config options myself, so feedback from people who do use them is very much appreciated!)
Jens Lehmann (2):
checkout: Add test for diff.ignoreSubmodules
checkout: Use submodule.*.ignore settings from .git/config and
.gitmodules
Documentation/config.txt | 3 ++- builtin/checkout.c | 5 +++++ t/t2013-checkout-submodule.sh | 23 +++++++++++++++++++++++ 3 files changed, 30 insertions(+), 1 deletions(-)
Signature · 1 line
1.7.2.2.515.g13860