Skip to content

De-couple sysfs memory directories from memory sections

Nathan Fontenot linux-mm linuxppc-dev lkml 1 version In review

Get series with b4
b4 am [email protected]

Versions newest first

  1. v1 Latest8 patches 5 repliesIn review

Patches in v1 No applies recorded yet

#Subject and filesSizeRepliesApplied
1/8Move find_memory_block() routinedrivers/base/memory.c+31 -310 replies
2/8Update memory block struct to have start and end phys indexdrivers/base/memory.c include/linux/memory.h+22 -90 replies
3/8Add section count to memory_block structdrivers/base/memory.c include/linux/memory.h+13 -70 replies
4/8Add mutex for adding/removing memory blocksdrivers/base/memory.c+7 -00 replies
5/8Allow a memory block to span multiple memory sectionsdrivers/base/memory.c+103 -450 replies
6/8Update node sysfs codedrivers/base/memory.c drivers/base/node.c include/linux/node.h+15 -70 replies
7/8Define memory_block_size_bytes() for powerpc/pseriesarch/powerpc/platforms/pseries/hotplug-memory.c+53 -130 replies
8/8Update memory hotplug documentationDocumentation/memory-hotplug.txt+30 -160 replies

Reviews trailers per patch

No Reviewed-by, Acked-by or Tested-by trailers for v1 yet.

Read the v1 thread

Cover letter [PATCH 0/8] De-couple sysfs memory directories from memory sections

This set of patches decouples the concept that a single memory section corresponds to a single directory in /sys/devices/system/memory/. On systems
with large amounts of memory (1+ TB) there are performance issues related to creating the large number of sysfs directories. For a powerpc machine with 1 TB of memory we are creating 63,000+ directories. This is resulting in boot times of around 45-50 minutes for systems with 1 TB of memory and 8 hours for systems with 2 TB of memory. With this patch set applied I am now seeing boot times of 5 minutes or less.

The root of this issue is in sysfs directory creation. Every time a directory is created a string compare is done against all sibling directories to ensure we do not create duplicates. The list of directory nodes in sysfs is kept as an unsorted list which results in this being an exponentially longer operation as the number of directories are created.

The solution solved by this patch set is to allow a single directory in sysfs to span multiple memory sections. This is controlled by an optional architecturally defined function memory_block_size_bytes(). The default definition of this routine returns a memory block size equal to the memory section size. This maintains the current layout of sysfs memory directories as it appears to userspace to remain the same as it is today.

For architectures that define their own version of this routine, as is done for powerpc in this patchset, the view in userspace would change such that each memoryXXX directory would span multiple memory sections. The number of sections spanned would depend on the value reported by memory_block_size_bytes.

In both cases a new file 'end_phys_index' is created in each memoryXXX directory. This file will contain the physical id of the last memory section covered by the sysfs directory. For the default case, the value in 'end_phys_index' will be the same as in the existing 'phys_index' file.

-Nathan Fontenot

--
To unsubscribe, send a message with 'unsubscribe linux-mm' in the body to [email protected]. For more info on Linux MM,
see: http://www.linux-mm.org/ .
Don't email: <a href=mailto:"[email protected]"> [email protected] </a>