Skip to content

RFC ARM Relocation Config Cleanup

Reinhard Meyer u-boot 1 version New

Get series with b4
b4 am [email protected]

Versions newest first

  1. v1 RFC Latest0 of 3 patches 0 repliesNew

Patches in v1 No applies recorded yet

None of the 3 patches the cover letter announces are in this archive.

Reviews trailers per patch

No Reviewed-by, Acked-by or Tested-by trailers for v1 yet.

Read the v1 thread

Cover letter [U-Boot] [PATCH RFC 0/3] ARM Relocation Config Cleanup

Dear Wolfgang Denk,

Quoted 2 lines

Wolfgang Denk (3):
Replace CONFIG_RELOC_FIXUP_WORKS by CONFIG_BROKEN_RELOC_FIXUP

Seems a slight misnomer to me, and a bit hides what it really does. What about CONFIG_NEEDS_DATA_RELOC_FIXUP ?

Quoted 10 lines
  arch/arm/cpu/arm1136/start.S           |  131 ----------------
  arch/arm/cpu/arm1176/start.S           |  218 --------------------------
  arch/arm/cpu/arm720t/start.S           |  107 -------------
  arch/arm/cpu/arm920t/start.S           |  146 ------------------
  arch/arm/cpu/arm925t/start.S           |  123 ---------------
  arch/arm/cpu/arm926ejs/orion5x/dram.c  |   15 --
  arch/arm/cpu/arm926ejs/start.S         |  100 ------------
  arch/arm/cpu/arm946es/start.S          |   87 -----------
  arch/arm/cpu/arm_intcm/start.S         |   89 -----------
  arch/arm/cpu/armv7/omap3/emif4.c       |   24 ---
Quoted 8 lines
  arch/arm/cpu/armv7/omap3/sdrc.c        |   28 ----
  arch/arm/cpu/armv7/omap4/board.c       |    5 -
  arch/arm/cpu/armv7/start.S             |  117 --------------
  arch/arm/cpu/ixp/start.S               |  205 -------------------------
  arch/arm/cpu/lh7a40x/start.S           |  115 --------------
  arch/arm/cpu/pxa/start.S               |   32 +---
  arch/arm/cpu/s3c44b0/start.S           |   87 -----------
  arch/arm/cpu/sa1100/start.S            |   90 -----------

Maybe for a future patch series:

Move all not ARM variant/not SoC specific parts (setting up stack, calling C functions, relocation and relocation fixup) to a common file (arch/arm/lib/generic_start.S), basically leaving only specific parts in the various arch/arm/cpu/*/start.S files. This would highly ease maintenance.

Best Regards,
Reinhard