add CNS3xxx AHCI support
Get series with b4
b4 am [email protected]Versions newest first · linked by author and title
- v2 Latest posting 2/20 of 3 patches 0 repliesNew
- v2 posting 1/20 of 3 patches 0 repliesSuperseded
Patches in v2 posting 2/2 No applies recorded yet
None of the 3 patches the cover letter announces are in this archive.
Reviews trailers per patch
No Reviewed-by, Acked-by or Tested-by trailers for v2 yet.
Cover letter [PATCH v2 0/3] add CNS3xxx AHCI support
Quoted 10 lines · Anton Vorontsov
On Thu, Jan 06, 2011 at 02:43:08PM +0800, Lin Mac wrote:
[...]Quoted 7 lines
Quoted 4 lines
It is overkill to rename the entirety of
ahci_platformjust for one override function.
This sort of thing I would have expected to be added directly toahci_platform.c.It might be overkill for only one controller. but it is more clean and readable to have different SoC specific changes in separate files, especially when more SoCs need to make similar changes.
Quoted 5 lines
I think that renaming the file is not necessary. You can just rename the module in the makefile.
Personally I like the current approach more than putting controller-specific fixups directly into
ahci_platform.
My main objection is the renaming. If ahci_platform wants to export some symbols for SoC modules like ahci_platform_cns, that's ok.
In general, follow the library approach rather than linking modules together in strange ways.
Jeff