Skip to content

ssb: improve device disabling

Larry Finger b43-dev linux-wireless 1 version New

Get series with b4
b4 am [email protected]

Versions newest first

  1. v1 Latest0 of 2 patches 0 repliesNew

Patches in v1 No applies recorded yet

None of the 2 patches the cover letter announces are in this archive.

Reviews trailers per patch

No Reviewed-by, Acked-by or Tested-by trailers for v1 yet.

Read the v1 thread

Cover letter [PATCH 0/2] ssb: improve device disabling
Quoted 8 lines · Rafa? Mi?ecki

With that patches we follow specs and (as recently proved by MMIO dumps) wl.

The more important patch is the first one. It detects problem (and warns) with SSB when it is in some broken state. We can for example hit such an issue when enabling DMA on 14e4:4329 (N-PHY, rev 1). The real fix is now known yet, but not we at least get warning. Switching to PIO on that card does not raise warning anymore (as expected).

Quoted 7 lines

We all hate regressions and Michal says than enabling/disabling SSB device can be tricky. I have tested that patches with few b43 driven devices:
14e4:4318 (BCM4318)
14e4:4315 (BCM4312)
14e4:4329 (BCM4321)
14e4:4328 (BCM4321)
14e4:432b (BCM4322)

I tested 14e4:4311 (BCM4311) and found no problems.

Larry