Add support for the MMC device to the vexpress
Get series with b4
b4 am [email protected]Versions newest first
- v2 Latest0 of 3 patches 0 repliesNew
Patches in v2 No applies recorded yet
None of the 3 patches the cover letter announces are in this archive.
Reviews trailers per patch
No Reviewed-by, Acked-by or Tested-by trailers for v2 yet.
Cover letter [U-Boot] [PATCH V2 0/3] Add support for the MMC device to the vexpress
Hi Reinhard,
Quoted 3 lines · Reinhard Meyer
Dear matt.waddel,
Quoted 2 lines
From: Matt Waddel<[email protected]>
<snip>
Quoted 3 lines
Sorry, my original comment still holds true for the naming, now the name suggests that this driver is generic to ARM devices, which clearly is not true.
Correct. However, this hardware device was developed by ARM (the company). As far as I know the other ARM mmc drivers, like the omap3_mmc, are not. So that would be the difference between the naming of these drivers.
I don't feel like this driver should be named after a particular platform like vexpress, since this driver could be used in any ARM hardware.
Quoted 4 lines
Can you list which devices have a MMCI that is covered by this driver? PL180 only? Or a series of PLxxx? It should be possible to find a naming that is more descriptive than "arm".
The PL180 is the name assigned to the hardware in the SOC. Here is the description of device from the 1st paragraph in the manual:
1.1 About the ARM PrimeCell Multimedia Card Interface (PL180)
The PrimeCell Multimedia Card Interface (MCI) is an Advanced
Microcontroller Bus Architecture(AMBA) compliant, System-on-a-Chip (SoC) peripheral that is developed, tested, and licensed by ARM.
----
As far as other platforms that use this hardware, it is in some of the other ARM EVMs and some STEricsson platforms like the u300 and u8500.
Quoted 3 lines
(That such a generic name slipped into the kernel must not imply we have to make the same mistake in u-boot)
I agree. However, it would be nice to have a bit of a link between the device in the kernel and the one in u-boot and I didn't think having "_mmci" in the name would be too objectionable.
Would pl180_mmci.c work? or how about arm_pl180_mmc.c? I'm open to other suggestions.
Best regards,
Matt
Quoted 3 lines
Best Regards,
Reinhard