OMAP 3 and 4 i2c fixes
Get series with b4
b4 am [email protected]Versions newest first
- v1 Latest4 patches 0 repliesNew
Patches in v1 No applies recorded yet
| # | Subject and files | Size | Replies | Applied |
|---|---|---|---|---|
| 1/4 | OMAP3 and 4 hwmod I2C units only allow 16 bit access | +0 | 1 reply | |
| 1/4 | OMAP3 and 4 hwmod I2C units only allow 16 bit access | +0 | 1 reply | |
| 1/4 | OMAP3 and 4 hwmod I2C units only allow 16 bit access | +0 | 0 replies | |
| 1/4 | OMAP3 and 4 hwmod I2C units only allow 16 bit access | +0 | 0 replies | |
| 2/4 | OMAP3 I2C document why cpu type and not peripheral unit ID used to probe | +0 | 1 reply | |
| 3/4 | OMAP3 and 4 i2c mark extended reg enums as extended only | +0 | 1 reply | |
| 3/4 | OMAP3 and 4 i2c mark extended reg enums as extended only | +0 | 0 replies | |
| 4/4 | OMAP3 and 4 I2C use cpu type consistently for new register availability | +0 | 0 replies |
Reviews trailers per patch
No Reviewed-by, Acked-by or Tested-by trailers for v1 yet.
Cover letter [PATCH 0/4] OMAP 3 and 4 i2c fixes
To summarize my comments on your series.
Quoted 4 lines · Andy Green
The following series fixes two issues with OMAP 3 and 4 i2c support.
First, hwmod tables don't have the i2c units marked up as being for 16-bit access only, which is mandatory.
That part is OK, and should just be extended to 2430 for the sake of completeness. A rev attribute should be added as well for the second part.
Quoted 3 lines
Second, the i2c peripheral unit init code is confused about using cpu_is...() and probed peripheral unit version, leading to OMAP3 i2c code doing the wrong thing and accessing nonexistant registers.
That part should be revisited to use a better way to identify the IP revision.
Most of the code is there, you just have to copy the correct information during I2C device init.
Just let me know if you are not comfortable with that latest part, some l-o folks, including me, can help you.
Thanks,
Benoit