I2C: OMAP: Fixes and removal of cpu_... from driver
Get series with b4
b4 am [email protected]Versions newest first
- v1 Latest3 of 18 patches 0 repliesNew
3 of 18 patches are in this archive. The cover letter announces 18.
Patches in v1 No applies recorded yet
| # | Subject and files | Size | Replies | Applied |
|---|---|---|---|---|
| 1/18 | I2C: OMAP2+: Set hwmod flags to only allow 16-bit accesses to i2c | +0 | 0 replies | |
| 4/18 | I2C: OMAP2+: Tag all OMAP2+ hwmod defintions with I2C IP revision | +0 | 0 replies | |
| 15/18 | I2C: OMAP2+: add correct functionality flags to all omap2plus i2c dev_attrarch/ | +10 | 2 replies |
Reviews trailers per patch
All 3 patches have a Reviewed-by or Acked-by of their own; the series has one for all of them.
| Patch | Benoit Cousson | Tony Lindgren |
|---|---|---|
| Series | A-b | |
| 1/18 | A-b | |
| 4/18 | A-b | |
| 15/18 | A-b |
Trailers given in replies are filled; those carried in the patches from earlier versions are outlined with dashes.
Cover letter [PATCH 2 00/18] I2C: OMAP: Fixes and removal of cpu_... from driver
Hi Andy,
Thanks for that really fast update. That looks pretty good at first glance. I still have to review in details.
And we need to find some volunteers for OMAP1 & 2 testing.
Thanks,
Benoit
Quoted 57 lines · Andy Green
The following series removes cpu_...() usage completely from the omap-i2c driver by having decisions about functional implementation choices in the SoC held in cpu-specific hwmod tables that are already established, or for OMAP1 where there is no hwmod, set at OMAP1-specific i2c bus addition time.
Along the way it solves two issues with the existing implementation, that only 16-bit accesses are documented to be allowed to the I2C peripheral unit, and that due to a confusion in the existing driver about whether it is faced with a newer IP version on OMAP3530, currently it writes to a random non-existent I2C register at times on that platform.
The patch series is quite extended from the first try thanks to comments from Benoit Cousson.
Patches are tested on OMAP3530 and OMAP4430 I have but will need confirming they don't break anything on OMAP1xxx and OMAP2xxx as agreed with Benoit.
---
Andy Green (18):
I2C: OMAP1/OMAP2+: prepend I2C IP version to probed version shown indev_info
I2C: OMAP2+: Convert omap I2C driver to use feature implementation flags from platform data
I2C: OMAP1: set i2c unit feature implementation flags in platform data
I2C: OMAP2+: add correct functionality flags to all omap2plus i2cdev_attr
I2C: OMAP1/OMAP2+: create omap I2C functionality flags for eachcpu_... test
I2C: OMAP2+: Pass flags up to omap i2cplatform_dataas well
I2C: OMAP1/OMAP2+: add flags field to omap i2c platform data
I2C: OMAP2+: increaseomap_i2c_dev_attrflags from u8 to u32
I2C: OMAP2+: address confused probed version naming
I2C: OMAP2+: Solve array bounds overflow error on i2c idle
I2C: OMAP2+: useplatform_dataip revision to select register map
I2C: OMAP2+: Pass hwmod rev knowledge viaplatform_datawhen i2c bus added
I2C: OMAP1: set IP revision in platform data
I2C: OMAP: add rev to omap i2c platform data
I2C: OMAP2+: Tag all OMAP2+ hwmod defintions with I2C IP revision
I2C: OMAP2+: Introduce I2C IP versioning constants
I2C: OMAP2+: Name registers in I2C IP V2 only accordingly
I2C: OMAP2+: Set hwmod flags to only allow 16-bit accesses to i2carch/arm/mach-omap2/omap_hwmod_2420_data.c | 8 ++ arch/arm/mach-omap2/omap_hwmod_2430_data.c | 6 ++ arch/arm/mach-omap2/omap_hwmod_3xxx_data.c | 13 ++++ arch/arm/mach-omap2/omap_hwmod_44xx_data.c | 18 ++++- arch/arm/plat-omap/i2c.c | 27 ++++++++ arch/arm/plat-omap/include/plat/i2c.h | 3 + drivers/i2c/busses/i2c-omap.c | 98 +++++++++++++++------------- include/linux/i2c-omap.h | 29 ++++++++ 8 files changed, 151 insertions(+), 51 deletions(-)