Skip to content

solos-pci: debugging fixes

Philip Prindeville netdev 1 version New

Get series with b4
b4 am [email protected]

Versions newest first

  1. v1 Latest2 patches 0 repliesNew

Patches in v1 No applies recorded yet

#Subject and filesSizeRepliesApplied
1/2solos-pci: Use VPI.VCI notation consistently throughout moduledrivers/atm/solos-pci.c+2 -20 replies
2/2solos-pci: Don't include pseudo-header in dump of framedrivers/atm/solos-pci.c+8 -10 replies

Reviews trailers per patch

No Reviewed-by, Acked-by or Tested-by trailers for v1 yet.

Read the v1 thread

Cover letter [PATCH 0/2] solos-pci: debugging fixes

From: Philip Prindeville <[email protected]>

Two patches for net-2.6 HEAD:

The first changes the one remaining instance where the VCI (virtual circuit identifier) is output before the VPI (virtual path identifier). Standard notation is VPI *then* VCI, and this is used everywhere else.

The second does a "pull" on the sk_buff to remove the "struct pkt_hdr" that prefaces the actual ATM frame data (and includes message type, message size, and VPI/VCI tuple). Logging is the last thing done before releasing the sk_buff, so the header can safely be pulled up at this point. Also, we alternate between using the term "device" and "port" in the driver, which is inconsistent and confusing. So we also change the term "device" to "port".