Skip to content

OMAP: l3: fixes and cleanup

Santosh Shilimkar linux-arm-kernel linux-omap 1 version New

Get series with b4
b4 am [email protected]

Versions newest first

  1. v1 Latest2 of 5 patches 0 repliesNew

2 of 5 patches are in this archive. The cover letter announces 5.

Patches in v1 No applies recorded yet

#Subject and filesSizeRepliesApplied
1/5OMAP3: l3: fix for "irq 10: nobody cared" message+0 -00 replies
2/5OMAP3: l3: fix omap3_l3_probe error path+0 -00 replies

Reviews trailers per patch

All 2 patches have a Reviewed-by or Acked-by.

PatchSantosh Shilimkar
1/5A-b
2/5A-b

Trailers given in replies are filled; those carried in the patches from earlier versions are outlined with dashes.

Read the v1 thread

Cover letter [PATCH 0/5] OMAP: l3: fixes and cleanup

Omar,

Quoted 16 lines · Omar Ramirez Luna

Based on the comments received for the first patch:
OMAP3: l3: fix for "irq 10: nobody cared" message[1], and quick skimming through the code.

Although there are still parenthesis that are not needed because of operator precedence, they were left for clarity.

E.g.:
(error>> 32)& 0xffff;

clear = (L3_AGENT_STATUS_CLEAR_IA<< int_type) |

         L3_AGENT_STATUS_CLEAR_TA;

---
[1] https://patchwork.kernel.org/patch/665141/

Quoted 8 lines

Omar Ramirez Luna (5):
OMAP3: l3: fix for "irq 10: nobody cared" message
OMAP3: l3: fix omap3_l3_probe error path
OMAP3: l3: minor cleanup for error message, parenthesis and extra
lines
OMAP4: l3: fix omap4_l3_probe error path
OMAP4: l3: minor cleanup for parenthesis and extra spaces

Thanks for the cleanup. I have reviewed the series and it looks good to me.
I would suggest to fold similar changes like,
- PATCH 2/5 and PATCH 4/5 into one patch
- PATCH 3/5 and PATCH 5/5 into one patch

With this update you can add my ack for this series

Quoted 4 lines
  arch/arm/mach-omap2/omap_l3_noc.c |   51 ++++++++++++++++--------------------
  arch/arm/mach-omap2/omap_l3_smx.c |   46 ++++++++++++---------------------
  2 files changed, 40 insertions(+), 57 deletions(-)