OMAP: l3: fixes and cleanup
Get series with b4
b4 am [email protected]Versions newest first
- v1 Latest2 of 5 patches 0 repliesNew
2 of 5 patches are in this archive. The cover letter announces 5.
Patches in v1 No applies recorded yet
| # | Subject and files | Size | Replies | Applied |
|---|---|---|---|---|
| 1/5 | OMAP3: l3: fix for "irq 10: nobody cared" message | +0 | 0 replies | |
| 2/5 | OMAP3: l3: fix omap3_l3_probe error path | +0 | 0 replies |
Reviews trailers per patch
All 2 patches have a Reviewed-by or Acked-by.
| Patch | Santosh Shilimkar |
|---|---|
| 1/5 | A-b |
| 2/5 | A-b |
Trailers given in replies are filled; those carried in the patches from earlier versions are outlined with dashes.
Cover letter [PATCH 0/5] OMAP: l3: fixes and cleanup
Omar,
Quoted 16 lines · Omar Ramirez Luna
Based on the comments received for the first patch:
OMAP3: l3: fix for "irq 10: nobody cared" message[1], and quick skimming through the code.Although there are still parenthesis that are not needed because of operator precedence, they were left for clarity.
E.g.:
(error>> 32)&0xffff;clear = (L3_AGENT_STATUS_CLEAR_IA<<
int_type) |L3_AGENT_STATUS_CLEAR_TA;
Quoted 8 lines
Omar Ramirez Luna (5):
OMAP3: l3: fix for "irq 10: nobody cared" message
OMAP3: l3: fixomap3_l3_probeerror path
OMAP3: l3: minor cleanup for error message, parenthesis and extra
lines
OMAP4: l3: fixomap4_l3_probeerror path
OMAP4: l3: minor cleanup for parenthesis and extra spaces
Thanks for the cleanup. I have reviewed the series and it looks good to me.
I would suggest to fold similar changes like,
- PATCH 2/5 and PATCH 4/5 into one patch
- PATCH 3/5 and PATCH 5/5 into one patch
With this update you can add my ack for this series
Quoted 4 lines
arch/arm/mach-omap2/omap_l3_noc.c | 51 ++++++++++++++++-------------------- arch/arm/mach-omap2/omap_l3_smx.c | 46 ++++++++++++--------------------- 2 files changed, 40 insertions(+), 57 deletions(-)