Skip to content

SQUASHME pnfs-obj: Lots of changes addressing comments by Trond and Benny

Boaz Harrosh linux-nfs 1 version In review

Get series with b4
b4 am [email protected]

Versions newest first

  1. v1 Latest12 of 13 patches 4 repliesIn review

12 of 13 patches are in this archive. The cover letter announces 13.

Patches in v1 No applies recorded yet

#Subject and filesSizeRepliesApplied
1/13SQUASHME: re-reorder the functions so it compares better with raids basefs/nfs/objlayout/objio_osd.c fs/nfs/objlayout/objlayout.c fs/nfs/objlayout/objlayout.h +1 more+186 -1821 reply
2/13SQUASHME: pnfs-obj: objio_segment only needs the pnfs_osd_layout->olo_compsfs/nfs/objlayout/objio_osd.c+12 -120 replies
3/13SQUASHME: pnfs-obj: Rename ios->objio_seg => ios->layoutfs/nfs/objlayout/objio_osd.c+24 -240 replies
5/13SQUASHME: pnfs-obj: Convert layout and deviceinfo decoding to new XDRfs/nfs/objlayout/objlayout.c fs/nfs/objlayout/objlayout.h fs/nfs/objlayout/pnfs_osd_xdr_cli.c +1 more+271 -3210 replies
6/13SQUASHME: pnfs-obj: Change API of objlayout_io_set_resultfs/nfs/objlayout/objio_osd.c fs/nfs/objlayout/objlayout.c fs/nfs/objlayout/objlayout.h+9 -70 replies
7/13SQUASHME: pnfs-obj: Avoid double allocation logic in objlayout_alloc_lsegfs/nfs/objlayout/objio_osd.c fs/nfs/objlayout/objlayout.c fs/nfs/objlayout/objlayout.h+97 -1080 replies
8/13SQUASHME: pnfs_osd_xdr: Remove Server API declarationsinclude/linux/pnfs_osd_xdr.h+0 -100 replies
9/13SQUASHME: pnfs_osd_xdr: Avoid using xdr_rewind_streamfs/nfs/objlayout/objlayout.c fs/nfs/objlayout/pnfs_osd_xdr_cli.c include/linux/pnfs_osd_xdr.h+36 -440 replies
10/13Bugs in new pnfs write pathfs/nfs/nfs4proc.c fs/nfs/pnfs.c+8 -53 replies
11/13SQUASHME: pnfs_osd_xdr: Add Server API for encoding/decoding osd XDRsfs/exportfs/pnfs_osd_xdr_srv.c include/linux/pnfs_osd_xdr.h+25 -120 replies
12/13SQUASHME: XDR API changes to pnfs_osd_xdr_decode_ioerr()fs/exofs/export.c+8 -100 replies
13/13SQUASHME: dbg Print the full device_id returnedfs/exofs/export.c+3 -20 replies

Reviews trailers per patch

No Reviewed-by, Acked-by or Tested-by trailers for v1 yet.

Read the v1 thread

Cover letter [PATCHSET 00/13] SQUASHME pnfs-obj: Lots of changes addressing comments by Trond and Benny

Submitted are SQUASHME patches on-top of *pnfs-exofs-all* that demonstrate all the changes I did addressing comments by Trond and Benny. So it is easy to see the changes and not need to review the complete patchset.

Thanks guys for the excellent review!

Next I will send a new *pnfs-submit* patchset so they can be reviewed and put in next. (Benny you need to come back to me if it is OK to submit the full read/write raid-engine
as one patch, instead of three)

Here is the list of SQUASHME patches:

[PATCH 01/13] SQUASHME: re-reorder the functions so it compares better with raids base

Benny decided to change functions order. This completely through off all the changes I had pending in my trees. This patch does nothing but moves code back to its original place. See as reply to this email the diff of the nice changes Benny did after the last tree at pnfs/pnfs-all-2.6.38

[PATCH 02/13] SQUASHME: pnfs-obj: objio_segment only needs the pnfs_osd_layout->olo_comps [PATCH 03/13] SQUASHME: pnfs-obj: Rename ios->objio_seg => ios->layout
[PATCH 04/13] SQUASHME: pnfs-obj: Fix groups code when num_devices is not divisible by group_width

These three are bug fixes and last minute code style changes

[PATCH 05/13] SQUASHME: pnfs-obj: Convert layout and deviceinfo decoding to new XDR

This one was requested by Trond and rightly so. It is now supported a bigger then 4K layout, using all the new(old) exr_stream API. Thanks Trond!

[PATCH 06/13] SQUASHME: pnfs-obj: Change API of objlayout_io_set_result [PATCH 07/13] SQUASHME: pnfs-obj: Avoid double allocation logic in objlayout_alloc_lseg

Another nice cleanup and performance boost.

[PATCH 08/13] SQUASHME: pnfs_osd_xdr: Remove Server API declarations

Remove the dependency on the exp_xdr header.

[PATCH 09/13] SQUASHME: pnfs_osd_xdr: Avoid using xdr_rewind_stream

Also requested by Trond

[PATCH 10/13] [RFC] Bugs in new pnfs write path

This is a resend of the BUGs patch to pnfs-core (So I can test the tree)

Below is some exofs changes needed to compile and test.
[PATCH 11/13] SQUASHME: pnfs_osd_xdr: Add Server API for encoding/decoding osd XDRs [PATCH 12/13] SQUASHME: XDR API changes to pnfs_osd_xdr_decode_ioerr() [PATCH 13/13] SQUASHME: dbg Print the full device_id returned

Benny could you submit these to the pnfs-exofs-all branch?

So next I'll send these already squashed into a new submit patchset

Thanks
Boaz