Skip to content

Some more bugs in latest code + please help with last problem

Boaz Harrosh linux-nfs 1 version New

Get series with b4
b4 am [email protected]

Versions newest first

  1. v1 Latest2 of 3 patches 0 repliesNew

2 of 3 patches are in this archive. The cover letter announces 3.

Patches in v1 No applies recorded yet

#Subject and filesSizeRepliesApplied
1/3SQUSHME: pnfs: BUG in _deviceid_purge_clientfs/nfs/pnfs_dev.c+1 -10 replies
3/3SQUASHME: pnfs-obj: objlayout wants to cache devices until unmountfs/nfs/objlayout/objio_osd.c+1 -00 replies

Reviews trailers per patch

No Reviewed-by, Acked-by or Tested-by trailers for v1 yet.

Read the v1 thread

Cover letter [PATCHS 0/3] Some more bugs in latest code + please help with last problem

I'm sending some more fixes.

After launch I will re-send all the fixes needed ontop of Benny's last tree as SQUASHMEs. One SQUASHME for each patch in the set that needs one.

Last sent fixes will have conflicts with newest code. So these re-sent will resolve that.

With this code, I'm able to use the global-device-cache the way It was with the old one. Also including all the fixes I'm able to do IO, and checkout a git tree!

*BUT*: Currently IO is very very slow, because wsize/rsize is set
to default 64k which is just one strip_unit for default objects. I used to set server->w/rsize on .set_layoutdriver but Benny removed that. What do you guys want to do with this? I can see to options:
1. Return the .set_layoutdriver where ld can set defaults the way it likes it.
2. If pnfs is used set w/rsize to MAX_UINT and let pg_test cap the sizes as see fit.

Please advise?

For now these:
SQUSHME: pnfs: BUG in _deviceid_purge_client
pnfs: layout_driver MUST set free_deviceid_node if using dev-cache
SQUASHME: pnfs-obj: objlayout wants to cache devices until unmount

Thanks
Boaz