submodule add: allow relative repository path even when no url is set
Get series with b4
b4 am [email protected]Versions newest first
- v1 Latest3 patches 5 repliesIn review
Patches in v1 No applies recorded yet
| # | Subject and files | Size | Replies | Applied |
|---|---|---|---|---|
| 1/3 | submodule add: test failure when url is not configured in superprojectt/ | +7 | 0 replies | |
| 2/3 | submodule add: allow relative repository path even when no url is setDocumentation/ git-submodule.sh t/ | +9 | 3 replies | |
| 3/3 | submodule add: clean up duplicated codegit-submodule.sh | +1 | 0 replies |
Reviews trailers per patch
No Reviewed-by, Acked-by or Tested-by trailers for v1 yet.
Cover letter [PATCH 0/3] submodule add: allow relative repository path even when no url is set
Am 05.06.2011 20:27, schrieb Junio C Hamano:
Quoted 6 lines
If you think about "absense of the remote in the superproject means the project originates from here", what you are doing in step 3. is to changing the origin of these set of projects. After changing the origin of these set of projects, isn't "git submodule sync" an established way to adjust to the change? I was hoping that that would update .git/config in step 3. so you wouldn't have the problem in step 4. at all.
Thanks for explaining that in detail, I think I do get it now.
So what about this series: The first commit adds a test for the error we are talking about, the second one implements the logic you proposed and the last one removes some duplicated code I stumbled across while staring at the code.
Jens Lehmann (3):
submodule add: test failure when url is not configured in
superproject
submodule add: allow relative repository path even when no url is set submodule add: clean up duplicated code
Documentation/git-submodule.txt | 4 +++- git-submodule.sh | 12 ++---------- t/t7400-submodule-basic.sh | 10 ++++++++++ 3 files changed, 15 insertions(+), 11 deletions(-)
Signature · 1 line
1.7.6.rc0.3.g28a66