Skip to content

Small change needed in nfs_xdr.h

Boaz Harrosh linux-nfs 1 version In review

Get series with b4
b4 am [email protected]

Versions newest first

  1. v1 Latest2 patches 1 replyIn review

Patches in v1 No applies recorded yet

#Subject and filesSizeRepliesApplied
1/2nfs_xdr: Move nfs4_string definition out of #ifdef CONFIG_NFS_V4include/linux/nfs_xdr.h+5 -51 reply
2/2exofs: pnfs-tree: Remove pnfs-osd private definitionsfs/exofs/exofs.h fs/exofs/pnfs.h+1 -500 replies

Reviews trailers per patch

1 of 2 patches has a Reviewed-by or Acked-by.

PatchTrond Myklebust
1/2A-b
2/2

Trailers given in replies are filled; those carried in the patches from earlier versions are outlined with dashes.

Read the v1 thread

Cover letter [PATCHSET 0/2] Small change needed in nfs_xdr.h

Hi trond

I need this simple patch:

[PATCH 1/2] nfs_xdr: Move nfs4_string definition out of #ifdef CONFIG_NFS_V4

exofs file system wants to use pnfs_osd_xdr.h file instead of redefining pnfs-objects types in it's private "pnfs.h" header.

Before we do the switch we must make sure pnfs_osd_xdr.h is compilable also under NFS versions smaller than 4.1. Since now it is needed regardless of version, by the exofs code.

Only miss-out is nfs4_string move it to global scope.

So I can submit this patch to the exofs tree:
[PATCH 1/2] exofs: pnfs-tree: Remove pnfs-osd private definitions

Now that pnfs-osd has hit mainline we can remove exofs's private header. (And the FIXME comment)

The small problem is that if we both keep a copy of the patch in linux-next, it will be fine until there are possibly more changes to nfs_xdr.h. git merge will not like that.

If you have another batch for this -rc you could include the patch and I'll rebase my linux-next on that -rc. Or we can risk having the same patch and if there are any more changes just ping me and I'll see what I do with linux-next. Or you can send me your ack-by: and I can submit it through exofs tree.

Thanks
Boaz