Skip to content

RFC Consolidation: move SMP local timers to driver/clocksource

Marc Zyngier linux-arm-kernel 1 version New

Get series with b4
b4 am [email protected]

Versions newest first

  1. v1 RFC Latest0 of 16 patches 0 repliesNew

Patches in v1 No applies recorded yet

None of the 16 patches the cover letter announces are in this archive.

Reviews trailers per patch

No Reviewed-by, Acked-by or Tested-by trailers for v1 yet.

Read the v1 thread

Cover letter [RFC PATCH 00/16] Consolidation: move SMP local timers to driver/clocksource
Quoted 25 lines · Rob Herring
Quoted 15 lines · Marc Zyngier
Quoted 14 lines · Rob Herring

Marc,

Quoted 10 lines · Marc Zyngier
Quoted 2 lines · Rob Herring

Also, device tree support for early platform devices would be useful for this.

What about the attached patch? I've used it to boot a VExpress board with the following DT snippet (and the corresponding support in the amp_smp_twd driver):

	localtimer at 2c000600 {
		device_type = "localtimer";
Quoted 8 lines
Quoted 4 lines

My understanding is device_type is only supposed to be used for devices with real OpenFirmware. You could just add localtimer or timer as a 2nd compatible string. I think localtimer is a bit of a Linux name, so just timer may be better.

Using "compatible" would not work. You'd have to add the same compatible string to all drivers, and get drivers probing the wrong device. Any other property we could use instead?

Quoted 6 lines

No, I'm saying you have a compatible property like this:

compatible = "arm,smp-twd", "timer";

You create the early platform device(s) based on matches with "timer", but match the driver based on "arm,smp-twd".

Right. What about the attached patch? Test-booted on the same VE with the above "compatible" property.

	M.
Signature · 1 line
Jazz is not dead. It just smells funny...