Re-jig cpu_suspend for a saner calling convention
Get series with b4
b4 am [email protected]Versions newest first
- v2 Latest1 of 25 patches 0 repliesNew
1 of 25 patches is in this archive. The cover letter announces 25.
Patches in v2 No applies recorded yet
| # | Subject and files | Size | Replies | Applied |
|---|---|---|---|---|
| 25/25 | ARM: pm: omap34xx: convert to generic suspend/resume support | +0 | 1 reply |
Reviews trailers per patch
No Reviewed-by, Acked-by or Tested-by trailers for v2 yet.
Cover letter [PATCH 00/25 v2] Re-jig cpu_suspend for a saner calling convention
Quoted 9 lines · Russell King - ARM Linux
Quoted 1 line · Russell King - ARM Linux
Tested on Assabet (SA1100) and 3430LDP only.
Correction - because suspend only goes into retention mode, these changes have not been tested on the 3430. Someone who knows what they're doing with the mega-complicated OMAPs (and so knows how to trigger the required modes to test these code paths) needs to test this.
Quoted 6 lines
It will currently fail when trying to call
cpu_resume()because we're trying the virtual address for that function, whereas it needs to be the physical address. That's left as an exercise to solve (easiest way is probably to passvirt_to_phys(cpu_resume)into_omap_sram_idleand get it to save that away in SRAM.)
Firstly thanks for taking time to include OMAP this time. Even if the changes are not tested, we can get them working with necessary fixes.
Have looked at your series briefly and have some comments for the same. Am planning to test these patches, but it might take bit more time.
Will update the results as soon as I have them.
Regards
Santosh