gpio/omap: driver cleanup and fixes
Get series with b4
b4 am CAMQu2gyZtuW3HLbWH5wH-YjB4SpLD9tz5kpVdRHi2j9RsXLA2w@mail.gmail.comVersions newest first · linked by author and title
- v9 Latest0 of 31 patches 0 repliesNew
- v70 of 26 patches 0 repliesSuperseded
Patches in v9 No applies recorded yet
None of the 31 patches the cover letter announces are in this archive.
Reviews trailers per patch
No Reviewed-by, Acked-by or Tested-by trailers for v9 yet.
Cover letter [PATCH v9 00/31] gpio/omap: driver cleanup and fixes
Tarun,
Quoted 36 lines · Tarun Kanti DebBarma
This series is continuation of cleanup of OMAP GPIO driver and fixes. The cleanup include getting rid of cpu_is_* checks wherever possible, use of
gpio_banklist instead of static array, use of unique platform specific value associated data member to OMAP platforms to avoid cpu_is_* checks. The series also include PM runtime support.Baseline:
git://github.com/khilman/linux-omap-pm.git
Branch: for_3.3/gpio-baseBaseline:
git://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux-2.6.git
Branch: master
Commit: b835c0fPower Tests
a) OMAP3430SDP
- Modifyboard-3430sdp.cfile to have multiple GPIO modules active ?with debounce timeout enabled.
- Enable CPU-Idle
- Enable UART timeouts
- Enable offmode
- echo mem >/sys/power/state
- Verify retention and offmode count incrementb) ZOOM3
- Enable CPU-Idle
- Enable UART timeout
- echo mem >/sys/power/state
- Wakeup system using serial keyboard
- Verify retention count incrementFunctional Tests
- Done on OMAP2430, OMAP3430SDP, ZOOM3, OMAP4430Bootup Test
- Done on OMAP1710
Quoted 15 lines
v9:
- Summary of Comments/Issues fixed
?* GPIO wakeup does not work
?* Call debounce clock enable/disable functions from PM runtime callbacks. ? ?This will avoid calling the functions from multiple places. ?* Modify description of following patch to match latest changes. ? ?gpio/omap: save and restore debounce registers
?* Use (bank->regs->set_dataout&&bank->regs->clr_dataout) together instead ? ?of using only one of them.
?* Removecpu_is_omapxxxx()checks fromset_gpio_trigger().
?*_gpio_dbck_enable()in runtime callback triggered fromomap_gpio_request? ?does not enable dbck becausedbck_enable_maskis not set at this point. ?* Workaround associated with an errata got missed in v8. This has been ? ? ?included.
As reported by Kevin ( off-the list), only 25 patches out of 31 reached to the list.
The rest 8, for some reason didn't reached to the list.
Also since you have added few additional bug fixes in this series on top of the v8, the v9 becomes slightly different.
So here is what I suggest.
1. Repost your v9 only with those 25 reworked patches.
2. Create a separate series for additional bug fixes which will apply on top of 1)
That way it's easier to line up the patches since the 25 ones have gone though few review cycles where as the new 8 has only gone through the internal review.
Regards
Santosh