Skip to content

RFC Rework of the debug() macro

Albert ARIBAUD u-boot 1 version New

Get series with b4
b4 am [email protected]

Versions newest first

  1. v1 RFC Latest0 of 39 patches 0 repliesNew

Patches in v1 No applies recorded yet

None of the 39 patches the cover letter announces are in this archive.

Reviews trailers per patch

PatchDetlev Zundel
SeriesA-b

Trailers given in replies are filled; those carried in the patches from earlier versions are outlined with dashes.

Read the v1 thread

Cover letter [U-Boot] [RFC] [PATCH 00/39] Rework of the debug() macro

Le 22/10/2011 03:18, Marek Vasut a ?crit :

Quoted 17 lines · Albert ARIBAUD
Quoted 16 lines

Hi Marek,

Le 22/10/2011 02:16, Marek Vasut a ?crit :

Quoted 12 lines

This patch series reworks the debug() and debugX() macro in include/common.h to be compatible with GCC 4.6.

This series needs further discussion:
* Some files suffer size growth with gcc4.2, why ?

- Possibility is that the GCC4.2 is incapable to optimize code out so deep

* Does this change break any platforms? Compile tested on PowerPC.

- Please run MAKEALL on your platforms to test this.

Quoted 8 lines
Quoted 2 lines

Any git branch we could pull and rebase on our trees rather than am'ing 39 patches one by one?

Please try:

git://git.denx.de/u-boot-marex.git , "debug" branch.

Cheers

A differential 'MAKEALL arm' (ELDK42) show a sharp rise in board not building properly, from 74 to 141 (out of a total of 248).

Of the 67 boards, many show , essentially due to a lot of printf format warnings such as:

ks8695eth.c: In function 'ks8695_eth_send':
ks8695eth.c:199: warning: format '%x' expects type 'unsigned int', but argument 4 has type 'volatile void *'

(in cm4008, cm41xx), or

lcd.c: In function 'lcd_setmem':
lcd.c:446: warning: format '%d' expects type 'int', but argument 2 has type 'u_long'
lcd.c:446: warning: format '%d' expects type 'int', but argument 3 has type 'u_long'

(in at91sam9261ek_nandflash). Another, different, case is smdk2410:

s3c2410_nand.c: In function 's3c2410_hwcontrol':
s3c2410_nand.c:59: error: 'DEBUG' undeclared (first use in this function) s3c2410_nand.c:59: error: (Each undeclared identifier is reported only once s3c2410_nand.c:59: error: for each function it appears in.) s3c2410_nand.c: In function 's3c2410_dev_ready':
s3c2410_nand.c:86: error: 'DEBUG' undeclared (first use in this function) s3c2410_nand.c: In function 'board_nand_init':

Seems like you're trading some warnings against some others, depending on the compiler. :(

Amicalement,

Signature · 1 line
Albert.

Read the cover letter in its thread