Skip to content

env: reworking + default/import individual vars

Gerlando Falauto u-boot 1 version New

Get series with b4
b4 am [email protected]

Versions newest first

  1. v0 Latest0 of 4 patches 0 repliesNew

Patches in v0 No applies recorded yet

None of the 4 patches the cover letter announces are in this archive.

Reviews trailers per patch

No Reviewed-by, Acked-by or Tested-by trailers for v0 yet.

Read the v0 thread

Cover letter [U-Boot] [PATCH v0 0/4] env: reworking + default/import individual vars
Quoted 3 lines · Wolfgang Denk

Dear Gerlando Falauto,

In

message<[email protected]>

Quoted 6 lines · you
Quoted 6 lines

This is a resubmission (after removing remove checkpatch errors) of
http://lists.denx.de/pipermail/u-boot/2011-September/102875.html

Here I am proposing a set of changes in the behaviour of the environment import/set_to_default functions.

Quoted 8 lines
Quoted 6 lines

PATCH 1:
Add a "new" himport_ex() function (reworking of himport_r which is now a wrapper around it), which has 3 new arguments:

"nvars", "vars":, number and list of variables to take into account (0 means ALL)

Hmmm.... I wonder how much testing you did.

I tested "env import" with and without -n. Same for "env default". Also tested special variables.

Quoted 1 line

For me, env import is broken now.

I am not able to see how it's obviously broken.
Perhaps you mean that when you don't provide an argument to -n, the following argument (e.g., -t) is interpreted as a variable name (and therefore consumed)? That doesn't look like an error to me. Could you please elaborate and/or provide a test case?

Thank you,
Gerlando Falauto