b43: reoder functions in phy_n.c
Get series with b4
b4 am [email protected]Versions newest first
- v1 Latest0 of 8 patches 0 repliesNew
Patches in v1 No applies recorded yet
None of the 8 patches the cover letter announces are in this archive.
Reviews trailers per patch
| Patch | Larry Finger |
|---|---|
| Series | A-b |
Trailers given in replies are filled; those carried in the patches from earlier versions are outlined with dashes.
Cover letter [PATCH 0/8] b43: reoder functions in phy_n.c
Quoted 31 lines · Rafa? Mi?ecki
[APPLYING] This patchset is based on top of wireless-next with:
b43: mark some vars__maybe_unusedinb43_nphy_pmu_spur_avoidapplied.As noted on b43-dev, we got really messy in
phy_n.c. Functions were implemented quite randomly, with specs appering during development, sometimes without knowing real mining of the routies.That resulted in code hard to read and with some not-so-nice early declarations.
This patches makes some cleaning with that code. It moves tons of LOCs, but I think we have to do this finally instead of going deeper and deeper into that mess.
As Larry suggested, I've made small patches and tried my best to get them formatted nicely, to have diffs really clean. I've been compiling b43 after each patch, so there shouldn't be any build breakage between.
Rafa? Mi?ecki (8):
b43: N-PHY: reorder functions: put basic ones at beginning
b43: N-PHY: reorder functions: collect radio ones
b43: N-PHY: reorder functions: collect samples ones
b43: N-PHY: reorder functions: collect RSSI selects
b43: N-PHY: split gain control workarounds
b43: N-PHY: reorder functions: move RSSI calibration
b43: N-PHY: reorder functions: move rest of workarounds
b43: N-PHY: reorder functions: random clenaups
Quoted 2 lines
drivers/net/wireless/b43/phy_n.c | 4575 +++++++++++++++++++------------------- 1 files changed, 2301 insertions(+), 2274 deletions(-)
I like all these patches, and you don't have to change anything. Note, that cleanups is misspelled in the subject line for #8.
Larry