Skip to content

pnfs-obj: Important BUG fixing also for @Stable

Boaz Harrosh linux-nfs 1 version In review

Get series with b4
b4 am [email protected]

Versions newest first

  1. v1 Latest2 patches 1 replyIn review

Patches in v1 No applies recorded yet

#Subject and filesSizeRepliesApplied
1/2pnfs-obj: pNFS errors are communicated on iodata->pnfs_errorfs/nfs/objlayout/objlayout.c+4 -00 replies
2/2pnfs-obj: Must return layout on IO errorfs/nfs/objlayout/objio_osd.c fs/nfs/pnfs.c fs/nfs/pnfs.h+15 -10 replies

Reviews trailers per patch

No Reviewed-by, Acked-by or Tested-by trailers for v1 yet.

Read the v1 thread

Cover letter [PATCHSET 0/2] pnfs-obj: Important BUG fixing also for @Stable

Hi Trond

I'm sending in two patches that fixes a bad hung, memory leak, a WARN_ON and plain wrong protocol handling. In regard to objlayout error handling. These are also aimed at Stable@ for the 3.2 Kernel.
(Actually these bugs are in since 3.0, I might produce another version
for 3.[1,0] after these go in)

I have simulated errors at various layers, reads and writes, in combination of different tests, and they work as I expect. .i.e IO continues to MDS and oblayout is returned on error.

Please include these patches for 3.3 and they can go to Stable@ for 3.2 has well.

list of patches:
[PATCH 1/2] pnfs-obj: pNFS errors are communicated on iodata->pnfs_error

This is just a stupidity and neglect. Benny can you understand what happened here?

[PATCH 2/2] pnfs-obj: Must return layout on IO error

This patch is mainly for pnfs.c but I think it is very simple and totally not affecting anybody but objlayout. So it should be safe, and does fixes my main problem.
Fred please review?

Please Review

Thanks
Boaz

Read the cover letter in its thread