tegra: Enhance funcmux to support I2C and MMC
Get series with b4
b4 am [email protected]Versions newest first
- v1 Latest0 of 7 patches 0 repliesNew
Patches in v1 No applies recorded yet
None of the 7 patches the cover letter announces are in this archive.
Reviews trailers per patch
No Reviewed-by, Acked-by or Tested-by trailers for v1 yet.
Cover letter [U-Boot] [PATCH 0/7] tegra: Enhance funcmux to support I2C and MMC
Quoted 7 lines · Simon Glass
This series expands
funcmux_select()to support configs other than 0, and to support options associated with a config.This permits introduction of I2C support using multiple config options.
The options parameter is used by MMC to select standard (4-bit) or 8-bit operation.
The unification in this series basically seems fine.
Why not consider bus width part of the "config" though, rather the complicating things with an extra parameter? As an example, for SDMMC4, you'd have say:
0: ATC + ATD 8 bit
1: ATB + GMA 4 bit
2: ATB + GMA + GME 8 bit
... and no option values.
Also, we should probably define names for the config values, at least in the cases where 0 isn't the only option. Hard-coding 0 or 1 at the call sites isn't very meaningful.
Oh, and SDMMC4's option 0 isn't correct: I think pin group ATB should be removed, since it contains signals SDIO4_CLK and SDIO4_CMD which are also part of pin group ATC, when those pin groups are set to function SDIO4 at least. I didn't check to see if any other similar problems exist.
Signature · 1 line
nvpublic