inet_diag: Fix old/new inet_diag_req-s structures
Get series with b4
b4 am [email protected]Versions newest first
- v1 Latest2 patches 2 repliesIn review
Patches in v1 No applies recorded yet
| # | Subject and files | Size | Replies | Applied |
|---|---|---|---|---|
| 1/2 | inet_diag: Rename inet_diag_req into inet_diag_req_v2include/ net/ net/ +2 more | +34 | 0 replies | |
| 2/2 | inet_diag: Rename inet_diag_req_compat into inet_diag_reqinclude/ net/ | +5 | 0 replies |
Reviews trailers per patch
None of the 2 patches has a Reviewed-by or Acked-by of their own; the series has one for all of them.
| Patch | Stephen Hemminger |
|---|---|
| Series | A-b |
| 1/2 | |
| 2/2 |
Trailers given in replies are filled; those carried in the patches from earlier versions are outlined with dashes.
Cover letter [PATCH 0/2] inet_diag: Fix old/new inet_diag_req-s structures
The recent changes to inet_diag broke the compilation of tools using kernel headers.
Fix this by doing two sequential renames:
inet_diag_req -> inet_diag_req_v2
inet_diag_req_compat -> inet_diag_req
After this the changes in the user-space visible part of the inet_diag.h are
* add the inet_diag_req_v2
* extend the INET_DIAG_ extensions list
The set applies to current net tree.
David, Stephen, I'm a little bit confused with the situation with this header. Can you please comment on the (quite ancient) commit 73c1f4a0 ([TCPDIAG]: Just rename everything to inet_diag) from acme@? This commit did the similar thing with inet_diag header -- flushed away the old struct and introduced a new one keeping just the binary compatibility. Why was the breakage of tools caused by this commit considered as acceptable?
Thanks,
Pavel