Skip to content

xenoprof: improve handling of 32-bit guests on 64-bit xen

Marcus Granado xen-devel 1 version NAK

Status from this message: NAK.

Get series with b4
b4 am [email protected]

Versions newest first

  1. v1 Latest3 patches 15 repliesNAK

Patches in v1

#Subject and filesSizeRepliesApplied
1/3xenoprof: Adjust indentationxen/arch/x86/oprofile/backtrace.c xen/arch/x86/oprofile/backtrace.c Wed Jan 18 17:23:02 2012 +0000+88 -881 reply
2/3xenoprof: Handle 32-bit guest stacks properly in a 64-bit hypervisorxen/arch/x86/oprofile/backtrace.c xen/arch/x86/oprofile/backtrace.c Wed Jan 18 17:35:06 2012 +0000+82 -143 replies
3/3xenoprof: Make the escape code consistent across 32 and 64-bit xenxen/include/public/xenoprof.h xen/include/public/xenoprof.h Wed Jan 18 17:46:28 2012 +0000+2 -211 replies

Reviews trailers per patch

No Reviewed-by, Acked-by or Tested-by trailers for v1 yet.

Read the v1 thread

Cover letter [PATCH 0/3] xenoprof: improve handling of 32-bit guests on 64-bit xen

Hi,
this patch series for xen fixes some xenoprofile type glitches between 64-bit xen and 32-bit guests, enablingthe opcontrol callgraph option to walk the call stack in both 32-bit and 64-bit guests when they are running on 64-bit xen.

The escape-code patch (3/3) should be used with a corresponding patch in the guest kernel definition of XENOPROF_ESCAPE_CODE so that both ends agree on the same escape constant value.

A few comments from my tests with oprofile 0.9.6 in userspace:
- to obtain callgraphs of the xen code, you need to enable the CONFIG_FRAME_POINTER flag during compilation of the xen binary, eg. using "make" with "frame_pointer=y".
- if the oprofiled daemon is running in a 32-bit guest, it needs to receive the xen-range in 32-bits, eg. --xen-image=/boot/xen-syms-4.1.1 --xen-range=80100000,801fe5ee

cheers,
Marcus

(1/3) xenoprof: Adjust indentation
(2/3) xenoprof: Handle 32-bit guest stacks properly in a 64-bit hypervisor (3/3) xenoprof: Make the escape code consistent across 32 and 64-bit xen