osd_uld: Important fix also for 3.2 Stable
Get series with b4
b4 am [email protected]Versions newest first
- v1 Latest1 patch 1 replyIn review
Patches in v1 No applies recorded yet
| # | Subject and files | Size | Replies | Applied |
|---|---|---|---|---|
| 1/1 | osd_uld: Bump MAX_OSD_DEVICES from 64 to 1,048,576drivers/ | +2 | 1 reply |
Reviews trailers per patch
No Reviewed-by, Acked-by or Tested-by trailers for v1 yet.
Cover letter [PATCHSET 0/1] osd_uld: Important fix also for 3.2 Stable
There was a mine hiding in the osd_uld driver. It was limited by the number of device minors it registers at startup which was 64.
The rest of the code is not limited at all and can hold as many devices as permitted by memory conditions.
The fix is very simple just bump the max number to the maximum minor permitted which is 2^20.
This is a serious BUG because some of the systems that intend to use the 3.2 Kernel to deploy pnfs. (Fedora 17 most probably) are bigger then 64 OSDs and will break.
I have tested this on 64bit platform and user-mode works just fine with this. (Kernel is not an issue). Might there be issues hiding in 32bit ARCHs. From reading the code I could not find any.
James would you like to take this through your tree for the next rc-fixes round or give me an ACK-BY: and I'll push it through the osd tree?
The patch:
[PATCH 1/1] osd_uld: Bump MAX_OSD_DEVICES from 64 to 1,048,576
Thanks
Boaz