Skip to content

i.mx28: Elimintated magic numbers for scratch register addresses

Stefano Babic u-boot 1 version New

Get series with b4
b4 am [email protected]

Versions newest first

  1. v1 Latest2 patches 0 repliesNew

Patches in v1 No applies recorded yet

#Subject and filesSizeRepliesApplied
1/2i.mx28: Added register definitions for DIGCTL registers+0 -00 replies
2/2i.mx28: Replaced magic numbers for scratch register addresses with register definitions+0 -00 replies

Reviews trailers per patch

No Reviewed-by, Acked-by or Tested-by trailers for v1 yet.

Read the v1 thread

Cover letter [U-Boot] [PATCH 0/2] i.mx28: Elimintated magic numbers for scratch register addresses
Quoted 8 lines · Marek Vasut
Quoted 4 lines

Marek, Stefano,

what kept you from accepting these patches? There was no objection on these.

The regs-digctl.h file being incomplete, it didn't contain all the bit definitions even though I shared the tool to convert file provided by FSL to uboot format.

My point: most of files in u-boot can be considered incomplete, because they do not define everything, but only what is *currently* used in U-boot.

I have not merged this patch because in the thread I read Robert wanted to send an updated patch, and this made this version automatically obsolete.

I agree we can merge this patch - and we can always push later a patch adding the bit definitions, when it will be necessary.

Best Regards,
Stefano

Signature · 5 lines
=====================================================================
DENX Software Engineering GmbH,     MD: Wolfgang Denk & Detlev Zundel
HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany
Phone: +49-8142-66989-0 Fax: +49-8142-66989-80  Email: office at denx.de
=====================================================================