Skip to content

omap hsmmc init cleanup and section warning fixes for v3.4 merge window

Rajendra Nayak linux-arm-kernel linux-mmc linux-omap 3 versions – New

Get series with b4
b4 am [email protected]

Versions newest first · linked by author and title

  1. v2 Latest posting 2/20 of 7 patches 0 repliesNew
  2. v2 posting 1/27 patches 0 repliesSuperseded
  3. v10 of 3 patches 0 repliesSuperseded

Patches in v2 posting 2/2 No applies recorded yet

None of the 7 patches the cover letter announces are in this archive.

Reviews trailers per patch

No Reviewed-by, Acked-by or Tested-by trailers for v2 yet.

Read the v2 thread

Cover letter [PATCH v2 0/7] omap hsmmc init cleanup and section warning fixes for v3.4 merge window
Quoted 6 lines · Tony Lindgren
Quoted 5 lines · Rajendra Nayak

Re-sending as these patches did not make it to the lists due to issues with my 'git send-email'

Hi Tony,

Quoted 8 lines
Quoted 5 lines

This is a re-spin of your series to fix up the section mismatch warnings noted by Russell with omap2_hsmmc_init(). The previous series had an issue around multiple insmod/rmmod of the twl4030 gpio driver when built as a module as reported by Russell again.

OK, can you please rebase your patches on hsmmc branch in linux-omap at commit 0e91c8ddf0e0932da59ec1d116e34049791b0e73?

Ok, will do.

Quoted 2 lines

Note that at least the hardcoded GPIO numbers are no longer needed.

Ok, I explained my rational in the other mail thread. Its always been hardcoded GPIO numbers and this will change only with DT as Benoit mentioned. I was just trying to make the hard-coding more readable. Will remove it and do it how it was done earlier, which is populate it in the callback.

Quoted 13 lines
Quoted 7 lines

There were 2 issues, one with gpio_requests failing as they were never freed on the module unload/unbind. The other was with the mmc devices being registered again. I have fixed both these issues in this series, mainly by having a .teardown hook for twl4030 gpio driver populated from all OMAP3 board files, which release all the requested gpios and also unregister the mmc omap/platform device.

Yes that's great.

Regards,

Tony