Fix a few warnings that bug me
Get series with b4
b4 am [email protected]Versions newest first
- v1 Latest3 of 9 patches 0 repliesNew
3 of 9 patches are in this archive. The cover letter announces 9.
Patches in v1 No applies recorded yet
| # | Subject and files | Size | Replies | Applied |
|---|---|---|---|---|
| 7/9 | Remove CONFIG_SYS_EXTBDINFO from snapper9260.h | +0 | 0 replies | |
| 8/9 | m68k: Change memsz to a signed char to avoid warning | +0 | 0 replies | |
| 9/9 | ppc: Change memsz variable to signed char | +0 | 0 replies |
Reviews trailers per patch
1 of 3 patches has a Reviewed-by or Acked-by.
| Patch | Stefano Babic |
|---|---|
| 7/9 | A-b |
| 8/9 | |
| 9/9 |
Trailers given in replies are filled; those carried in the patches from earlier versions are outlined with dashes.
Cover letter [U-Boot] [PATCH 0/9] Fix a few warnings that bug me
Quoted 8 lines · Simon Glass
Yes but not just those. There are detailed notes with each patch, but here is a summary. I think 6 out of 9 patches should be applied regardless of toolchain.
68k only:
arch/m68k/lib/board.c | 2 +-- I believe this fix is sensible for the reasons described in the patch, regardless of what the toolchain does.
Agree - I will send my ACK and merge it into my u-boot-staging
Quoted 3 lines
arch/powerpc/lib/board.c | 7 +--- Similar to the68k patch, again I think it makes sense to apply this. The variable is unsigned char for no good reason.
Agree, there is no reason. I will merge also this one into u-boot-staging.
Quoted 5 lines
Sandbox:
arch/sandbox/cpu/os.c | 11 +++--- This should be applied as it is not toolchain dependent (Mike may have picked it up already)
Ok, the patch has already found its way to mainline
Quoted 9 lines
ARM and PPC:
drivers/usb/host/ohci-hcd.c | 26 ++++++------- These happen with my 4.4.4 compiler, apparently not on 4.6. Drop them if you like.
ARM:
include/configs/snapper9260.h | 1 -- This fixes a real problem regardless of toolchain.
Right. I will send my ACK with CC to Albert. He can pick-up it directly into u-boot-arm.
Best regards,
Stefano
Signature · 5 lines
===================================================================== DENX Software Engineering GmbH, MD: Wolfgang Denk & Detlev Zundel HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany Phone: +49-8142-66989-0 Fax: +49-8142-66989-80 Email: office at denx.de =====================================================================