rbd: cleanups related to argument parsing
Get series with b4
b4 am [email protected]Versions newest first
- v1 Latest5 patches 1 replyIn review
Patches in v1 No applies recorded yet
| # | Subject and files | Size | Replies | Applied |
|---|---|---|---|---|
| 1/5 | rbd: encapsulate argument parsing for rbd_add()drivers/ | +42 | 0 replies | |
| 2/5 | rbd: don't use sscanf() in rbd_add_parse_args()drivers/ | +85 | 0 replies | |
| 3/5 | rbd: do a few checks at build timedrivers/ | +12 | 0 replies | |
| 4/5 | rbd: have rbd_parse_args() report found mon_addrs sizedrivers/ | +13 | 0 replies | |
| 5/5 | rbd: don't allocate mon_addrs buffer in rbd_add()drivers/ | +9 | 0 replies |
Reviews trailers per patch
None of the 5 patches has a Reviewed-by or Acked-by of their own; the series has one for all of them.
| Patch | Sage Weil |
|---|---|
| Series | R-b |
| 1/5 | |
| 2/5 | |
| 3/5 | |
| 4/5 | |
| 5/5 |
Trailers given in replies are filled; those carried in the patches from earlier versions are outlined with dashes.
Cover letter [PATCH 0/5] rbd: cleanups related to argument parsing
This series affects the way arguments are parsed in rbd_add(). It first encapsulates the code into its own helper function. Then it uses a few simple tokenization functions instead of sscanf() to parse the string provided, which makes it possible to do a better job of error checking the input. It makes use of the ability to check for certain invariants at build time rather than runtime. And by reworking what information gets passed around, eliminates the need to allocate a buffer to hold the monitor addresses.
-Alex