Skip to content

libceph: clean up some code involving CRCs

Alex Elder ceph-devel 1 version In review

Get series with b4
b4 am [email protected]

Versions newest first

  1. v1 Latest3 patches 2 repliesIn review

Patches in v1 No applies recorded yet

#Subject and filesSizeRepliesApplied
1/3libceph: use "do" in CRC-related Boolean variablesinclude/linux/ceph/messenger.h net/ceph/messenger.c+21 -210 replies
2/3libceph: separate CRC calculation from byte swappingnet/ceph/messenger.c+17 -140 replies
3/3libceph: do crc calculations outside loopnet/ceph/messenger.c+12 -140 replies

Reviews trailers per patch

None of the 3 patches has a Reviewed-by or Acked-by of their own; the series has one for all of them.

PatchSage Weil
SeriesR-b
1/3
2/3
3/3

Trailers given in replies are filled; those carried in the patches from earlier versions are outlined with dashes.

Read the v1 thread

Cover letter [PATCH 0/3] libceph: clean up some code involving CRCs

Rename a few variables so it's clearer which indicate that a CRC should be computed and which hold an actual CRC value. Separate CRC calculation from byte swapping to improve readability. And move some code that runs on only on the last pass through a couple of loops outside the loop body.

-Alex