MMC: mmci: Provide bindings for Device Tree
Get series with b4
b4 am [email protected]Versions newest first
- v1 Latest0 of 5 patches 0 repliesNew
Patches in v1 No applies recorded yet
None of the 5 patches the cover letter announces are in this archive.
Reviews trailers per patch
No Reviewed-by, Acked-by or Tested-by trailers for v1 yet.
Cover letter [PATCH 0/5] MMC: mmci: Provide bindings for Device Tree
Quoted 15 lines · Arnd Bergmann
Quoted 5 lines · Lee Jones
Quoted 5 lines
I would like to see what the minimal required change is to support DT for mmci without factorization.
1. Minimal change in mmci.
2. Addmmci_dt.cwhich contains the DT-populate code.Quoted 8 lines
Quoted 3 lines
The factorization could be done as step 2 I think.
What do you say?
I'm wondering what the difference is as the work has already been done.
It was Arnd's suggestion to separate out the two types of variants, and I'm quite fond of the new (fully featured) layout.
Quoted 7 lines
Right, I usually prefer cleanups or other refactoring to be done first, and then features added on top.
You could in theory add have just patches 3/4/5 all applied without the refactoring, but that I would be worried that this causes dependencies between the mmci driver and ux500 specific functionality like the
stedma40_filterfunction.
It's a possibility that we may have run into that even with this new layout. Remember you suggested that the u300 variant may be better off going into the ARM variant's file, but I wasn't quite sure, as it was an ST product. Well the afore mentioned function may still cause us some trouble. I am in the mists of some regression testing now. I'll report back when I know more.
Kind regards,
Lee
Signature · 5 lines
Lee Jones Linaro ST-Ericsson Landing Team Lead M: +44 77 88 633 515 Linaro.org ? Open source software for ARM SoCs Follow Linaro: Facebook | Twitter | Blog