ARM: OMAP: boards: changes to support dynamic irq alloc

Quoted 26 lines · Cousson, Benoit

Hi Tony,

Quoted 11 lines · Tony Lindgren

Quoted 7 lines · Tarun Kanti DebBarma

These two patches incorporate changes to OMAP1 and OMAP2 platforms board files whereby older references to OMAP_GPIO_IRQ macro are now replaced with gpio_to_irq(), thereby getting rid of static irq references.

Reference: git://git.kernel.org/pub/scm/linux/kernel/git/arm/arm-soc.git omap/dt
Commit: 9a0cee711448335ec43eae83272495e9334c0098

Can you please tell the exact two commits causing this breakage?

Well, this is the GPIO DT + SPARSE_IRQ series I have done. It appears that the boards I have were already using properly gpio_to_irq() and thus were working fine with this series.

But this is unfortunately not the case of most OMAP2 and 3 legacy boards that were still using an old OMAP way of converting GPIO to IRQ and were never modified to take advantage of the gpiolib stuff.

So if these patches are apply before the GPIO DT + SPARSE_IRQ series, there will be no breakage at all.

Quoted 5 lines

All the cleanup we have never done before will hurt us at some point when we will start using more extensively newer fmwk (DT, sparse_irq, dmaengine...). It was not done on purpose, but this GPIO series highlighted this remaining static broken mapping inside OMAP boards.

Yes I understand. But still, which patch(s) cause the issue so we can put that in the changelog for the fixes?

Quoted 7 lines

Quoted 4 lines

I'm baffled how despite all the effort for previnting issues like this this still happen. These all seem valid fixes and clean up things, but how come this was not seen earlier?

Maybe because there are much more boards inside mach-omap2 directory than inside my cubicle... :-(

Well somehow we need to make sure that patches get properly tested on a reasonable selection of boards. This pretty much breaks things for 21 boards out of the 51 board-*.c files :(