Skip to content

RFC OMAP4 cpuidle cleanup

Daniel Lezcano linux-arm-kernel linux-omap 1 version New

Get series with b4
b4 am [email protected]

Versions newest first

  1. v1 RFC Latest0 of 7 patches 0 repliesNew

Patches in v1 No applies recorded yet

None of the 7 patches the cover letter announces are in this archive.

Reviews trailers per patch

No Reviewed-by, Acked-by or Tested-by trailers for v1 yet.

Read the v1 thread

Cover letter [RFC][PATCH 0/7] OMAP4 cpuidle cleanup
Quoted 22 lines · Jean Pihet
Quoted 20 lines · Santosh Shilimkar

Daniel,

Quoted 17 lines · Daniel Lezcano

This patchset is a proposition to improve a bit the code. The changes are code cleanup and does not change the behavior of the driver itself.

A couple a things call my intention. Why the cpuidle device is set for cpu0 only and why the WFI is not used ?

Daniel Lezcano (7):
ARM: OMAP4: cpuidle - Remove unused valid field
ARM: OMAP4: cpuidle - Declare the states with the driver declaration
ARM: OMAP4: cpuidle - Remove the cpuidle_params_table table
ARM: OMAP4: cpuidle - fix static omap4_idle_data declaration
ARM: OMAP4: cpuidle - Initialize omap4_idle_data at compile time
ARM: OMAP4: cpuidle - use the omap4_idle_data variable directly
ARM: OMAP4: cpuidle - remove omap4_idle_data initialization at boot
time

Quoted 8 lines
Quoted 2 lines

The series looks fine to me in general. This clean-up is applicable for OMAP3 cpuidle code as well.

Great!
However OMAP3 has a few specific things that cannot be removed as easily:
- the 'valid' flag is used because only certain combinations of power domains states are possible,
- the latency settings can be overriden by the board code, so the cpuidle_params struct is needed.

Right, I noticed that. I am looking for a way to have a similar cleanup for omap3 but without breaking the rx51 board.

Thanks
-- Daniel

Quoted 11 lines
Quoted 8 lines

I want Jean to look at this series because some of his earlier clean up has introduced those custom functions which are getting removed in this series.

Regards
santosh

Thanks,
Jean

Signature · 5 lines
  <http://www.linaro.org/> Linaro.org ? Open source software for ARM SoCs

Follow Linaro:  <http://www.facebook.com/pages/Linaro> Facebook |
<http://twitter.com/#!/linaroorg> Twitter |
<http://www.linaro.org/linaro-blog/> Blog

Read the cover letter in its thread