Skip to content

RFC DMA engine conversion

Shubhrajyoti linux-arm-kernel linux-mmc linux-omap 1 version New

Get series with b4
b4 am [email protected]

Versions newest first

  1. v1 RFC Latest0 of 8 patches 0 repliesNew

Patches in v1 No applies recorded yet

None of the 8 patches the cover letter announces are in this archive.

Reviews trailers per patch

PatchShubhrajyoti
SeriesT-b

Trailers given in replies are filled; those carried in the patches from earlier versions are outlined with dashes.

Read the v1 thread

Cover letter [RFC 0/8] DMA engine conversion
Quoted 12 lines · Santosh
Quoted 12 lines

conversion process is fairly straight forward - it's more or less:

Quoted 11 lines

1. add struct dma_chan * pointer to the private structure.
2. add allocation/freeing functions for the DMA engine channels.
3. convert the callbacks to match the DMA engine callback prototype.
4. add code to set the DMA engine channel configuration appropriately (avoiding any unnecessary calls) via dmaengine_slave_config().
5. add code to queue the transfer via dmaengine_prep_slave_sg() and dmaengine_submit().
6. omap_start_dma() becomes dma_async_issue_pending().

 drivers/spi/spi-omap2-mcspi.c |  186 +++++++++++++++++++++++++++++++++-------
 1 files changed, 153 insertions(+), 33 deletions(-)
Quoted 7 lines

The patch seems to be fine to me.

Am looping Shubro in case he has any comment on "why element sync was used ?" and also to test the patch with more peripherals connected over SPI.

Regards
Santosh

Tested on omap4 ethernet and omap3 touchscreen
also did a spidev test.

Tested-by Shubhrajyoti <shubhrajyoti at ti.com <mailto:[email protected]>>