RFC DMA engine conversion
Get series with b4
b4 am [email protected]Versions newest first
- v1 RFC Latest0 of 8 patches 0 repliesNew
Patches in v1 No applies recorded yet
None of the 8 patches the cover letter announces are in this archive.
Reviews trailers per patch
| Patch | Shubhrajyoti |
|---|---|
| Series | T-b |
Trailers given in replies are filled; those carried in the patches from earlier versions are outlined with dashes.
Cover letter [RFC 0/8] DMA engine conversion
Quoted 12 lines · Santosh
Quoted 12 lines
conversion process is fairly straight forward - it's more or less:
Quoted 11 lines
1. add struct
dma_chan* pointer to the private structure.
2. add allocation/freeing functions for the DMA engine channels.
3. convert the callbacks to match the DMA engine callback prototype.
4. add code to set the DMA engine channel configuration appropriately (avoiding any unnecessary calls) viadmaengine_slave_config().
5. add code to queue the transfer viadmaengine_prep_slave_sg()anddmaengine_submit().
6.omap_start_dma()becomesdma_async_issue_pending().drivers/spi/spi-omap2-mcspi.c | 186 +++++++++++++++++++++++++++++++++------- 1 files changed, 153 insertions(+), 33 deletions(-)
Quoted 7 lines
The patch seems to be fine to me.
Am looping Shubro in case he has any comment on "why element sync was used ?" and also to test the patch with more peripherals connected over SPI.
Regards
Santosh
Tested on omap4 ethernet and omap3 touchscreen
also did a spidev test.